•  


pkgsite: doesn't handle non-ascii package name, regression compared to godoc · Issue #43036 · golang/go · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036

Closed
maruel opened this issue Dec 6, 2020 · 3 comments
Closed

pkgsite: doesn't handle non-ascii package name, regression compared to godoc #43036

maruel opened this issue Dec 6, 2020 · 3 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
pkgsite/godoc.org...

Comments

@maruel
Copy link
Contributor

Discovered while investigating #43035 :

pkg.go.dev fails at loading a non-ascii package name https://pkg.go.dev/github.com/maruel/panicparse/v2/cmd/panic/internal/%C3%B9tf8
but godoc succeeds: https://godoc.org/github.com/maruel/panicparse/cmd/panic/internal/%c3%b9tf8

Feels like a regression to me. @julieqiu

@maruel maruel mentioned this issue Dec 6, 2020
Closed
@julieqiu julieqiu added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. pkgsite labels Dec 7, 2020
@julieqiu
Copy link
Member

Marking this as WaitingForInfo on #43035 . Pkg.go.dev currently skips import paths that don't pass module.CheckImportPath .

@julieqiu julieqiu added this to the pkgsite/unplanned milestone Dec 7, 2020
@maruel
Copy link
Contributor Author

Since #43035 is WAI and there's going to be a release note as per #43052 , you can mark it WAI. Maybe worth pinging Bryan to clarify that pkg.go.dev enforces this too.

@julieqiu
Copy link
Member

SGTM - closing as WAI.

/cc @bcmills @jayconrod @matloob

@imjasonh imjasonh mentioned this issue Jan 28, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub . Already have an account? Sign in .
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
pkgsite/godoc.org-redirect
Development

No branches or pull requests

3 participants
@maruel @julieqiu @gopherbot
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close