•  


?? Dark mode by romaintalleu · Pull Request #100 · rileytestut/Delta · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

?? Dark mode #100

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

?? Dark mode #100

wants to merge 5 commits into from

Conversation

romaintalleu
Copy link

Tested on iOS 12.3.1, iOS 14.4 & iPadOS 14.3

Please test all screens and tell me if have missing screens and if necessary change colour for the dark mode. ??

IMG_0347
IMG_0348
IMG_0349

@xav42mac
Copy link

Go merge ! ??

@lonkelle
Copy link
Collaborator

It looks like you made the Dark Mode colors uniform. Right now we use a combination of "OLED Dark Mode" and "Grey Dark Mode".

It looks like you went with a full "Grey Dark Mode". Maybe we should have a global setting for "OLED Dark Mode" toggled on and off for pure blacks or your grey dark mode.

What do you think @romaintalleu ?

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@romaintalleu @xav42mac @lonkelle
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close