•  


enhanced the download.sh script for better usability by rjarun8 · Pull Request #52 · meta-llama/codellama · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhanced the download.sh script for better usability #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

enhanced the download.sh script for better usability #52

wants to merge 3 commits into from

Conversation

rjarun8
Copy link

Enhancement on file: download.sh #51

@facebook-github-bot
Copy link

Hi @rjarun8 !

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement , and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla . If you are contributing on behalf of someone else (eg your employer) , the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed . The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com . Thanks!

@rjarun8
Copy link
Author

CLA Signed 

Thank you!
Thank you for taking the time to register as an open source contributor. You may print the submission below for your records. You can resubmit this form to update your name or email. If you would like to make any other changes, please email [cla@meta.com](mailto:cla@meta.com) with your details.

We will now be able to accept any pull requests that you make to projects on our [GitHub account](https://github.com/facebook). If you already submitted a pull request before signing the CLA, then we will add a confirmation comment on that pull request (this might take several minutes). If you haven't submitted a pull request yet, then we look forward to your future contributions!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

samuelselvan
samuelselvan reviewed Sep 6, 2023
View reviewed changes
download.sh Outdated

# Function to download a file
download_file() {
wget -c --quiet --show-progress $1 -O $2 &
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Should we do quiet? since the downloads could take hours at times, should we allow to show the progress?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Or actually pass a param would be nice or to keep it simple, possibly just echo the first 100 chars of the url

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

thanks for the comments. we are now taking a praram interactively.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

so now the download_file() will operate based on verbosity choice and download_model has been modified to capture this as well

samuelselvan
samuelselvan reviewed Sep 6, 2023
View reviewed changes
download.sh
ALL_MODELS="7b,13b,34b,7b-Python,13b-Python,34b-Python,7b-Instruct,13b-Instruct,34b-Instruct"
log "${YELLOW}?? Enter the list of models to download ($ALL_MODELS) example: 7b,13b , or press Enter for all: ${NC}"
read MODEL_SIZE
log "Press 'c' to cancel or any other key to continue."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

We have a log at line 82, do we need this as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

In case he changes his mind ;)

download.sh Outdated

# Function to download a file
download_file() {
wget -c --quiet --show-progress $1 -O $2 &
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Or actually pass a param would be nice or to keep it simple, possibly just echo the first 100 chars of the url

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@samuelselvan samuelselvan samuelselvan left review comments

@jgehring jgehring Awaiting requested review from jgehring

@ruanslv ruanslv Awaiting requested review from ruanslv

@agunapal agunapal Awaiting requested review from agunapal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
@rjarun8 @facebook-github-bot @samuelselvan @rjarun8235
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close