•  


[Python build] Add --preset arg to generated cmake CLI by mfdeveloper · Pull Request #966 · firebase/firebase-unity-sdk · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python build] Add --preset arg to generated cmake CLI #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mfdeveloper
Copy link

@mfdeveloper mfdeveloper commented Mar 11, 2024

Description

  • Add --preset arg to cmake CLI.

    The scripts/build_scripts/build_zips.py verify if at least one of files: CMakePresets.json or CMakeUserPresets.json exists, and lookup the first preset name that starts with firebase-sdk-unity . That configuration file is used by cmake build (e.g define cache and/or environment variables).

    Optionally, you can pass a custom preset name to the build script with: --preset arg:

     python ./scripts/build_scripts/build_zips.py --preset=my-custom-preset --platform=windows
    
  • Add --generator flag that adds -G arg to cmake CLI

    If you're using Visual Studio 2022 , now you can override the default Visual Studio 2019 generator with --generator flag:

     python ./scripts/build_scripts/build_zips.py --generator=
    '
    Visual Studio 17 2022
    '
     --platform=windows
    

This PR is related with #646 , that mention the usage of cmakesettings.json , which one is deprecated!


Testing

  1. Clone or download this repo
  2. Locally, add a file CMakePresets.json or CMakeUserPresets.json to the repo root path, like the example below:
{

  "version"
: 
3
,

  // Your local cmake CLI version (optional)

  "cmakeMinimumRequired"
: 
{

    "major"
: 
3
,

    "minor"
: 
22
,

    "patch"
: 
0

  }
,

  "configurePresets"
: 
[

    {

      "name"
: 
"firebase-unity-sdk-default"
,

      "displayName"
: 
"Firebase Unity SDK x64 Debug"
,

      "description"
: 
"Sets Ninja generator, compilers, x64 architecture, build and install directory, debug build type"
,

      "generator"
: 
"Ninja"
,

      "binaryDir"
: 
"${sourceDir}/out/build/${presetName}"
,

      "cacheVariables"
: 
{

        "CMAKE_BUILD_TYPE"
: 
"Debug"
,

        "CMAKE_INSTALL_PREFIX"
: 
"${sourceDir}/out/install/${presetName}"
,

        "UNITY_ROOT_DIR"
: 
"[YOUR_UNITY_EDITOR_PATH]"
,

        "UNITY_CSHARP_BUILD_EXE"
: 
"[YOUR_UNITY_XBUILD_PATH_FILE]"
,

        "UNITY_MONO_EXE"
: 
"[YOUR_UNITY_MONO]"
,

        "MONO_EXE"
: 
"[GLOBAL_MONO]"
,

        "MONO_CSHARP_BUILD_EXE"
: 
"[YOUR_MONO_OR_MSBUILD]"

      }
,

      "environment"
: 
{

        "OPENSSL_ROOT_DIR"
: 
"[YOUR_OPENSSL_ROOT_DIR]"
,

        "OPENSSL_INCLUDE_DIR"
: 
"$env{OPENSSL_ROOT_DIR}/include/openssl"
,

        "OPENSSL_LIBRARIES"
: 
"$env{OPENSSL_ROOT_DIR}/lib"
,

        "OPENSSL_CRYPTO_LIBRARY"
: 
"$env{OPENSSL_ROOT_DIR}/lib/libcrypto.lib"

      }

    }

  ]

}
  1. Run the build_zips.py script
  python ./scripts/build_scripts/build_zips.py --platform=windows --targets=analytics

  
#
 The generated cmake CLI should be:

  cmake_setup_args is: cmake [REPO_ROOT_PATH] --preset firebase-unity-sdk-[something] ...
  1. Add the --generator flag in order to customize your VS version
  python ./scripts/build_scripts/build_zips.py --generator=
'
Visual Studio 17 2022
'
 --platform=windows

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@mfdeveloper mfdeveloper force-pushed the feature/cmake-preset-from-file branch 3 times, most recently from e2ac9f4 to 4de4230 Compare March 11, 2024 15:05
* Add --generator flag that adds -G arg to cmake CLI
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본