•  


Set LRU GC as the default for memory cache. by wu-hui · Pull Request #5823 · firebase/firebase-android-sdk · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LRU GC as the default for memory cache. #5823

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set LRU GC as the default for memory cache. #5823

wants to merge 2 commits into from

Conversation

wu-hui
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
?? Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by ?? Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited

Unit Test Results

???180 files? ±0?????180 suites? ±0???4m 6s ?? +6s
1?228 tests ±0??1?212 ?? ±0??16 ?? ±0??0 ? ±0?
2?480 runs? ±0??2?448 ?? ±0??32 ?? ±0??0 ? ±0?

Results for commit 7db4507 .?± Comparison against base commit 6c3fc22 .

?? This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.80% ( 6c3fc22 ) to 44.79% ( 55337e3 ) by -0.02% .

    Filename Base ( 6c3fc22 ) Merge ( 55337e3 ) Diff
    DeleteMutation.java 90.48% 95.24% +4.76%
    FirebaseFirestoreSettings.java 77.53% 76.40% -1.12%
    Firestore.kt 42.31% 36.54% -5.77%
    MemoryComponentProvider.java 82.93% 95.12% +12.20%
    MemoryEagerGcSettings.java 71.43% 0.00% -71.43%
    MemoryLruGcSettings.java 62.50% 87.50% +25.00%
    PatchMutation.java 100.00% 98.39% -1.61%
    SetMutation.java 97.22% 94.44% -2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KkVXPfDCAr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited

Size Report 1

Affected Products

  • firebase-firestore

    Type Base ( 6c3fc22 ) Merge ( 55337e3 ) Diff
    aar 1.41 MB 1.41 MB +6 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0QDJ3PzTLq.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    Device Statistics Distributions
    oriole-32
    Percentile 6c3fc22 55337e3 Diff Significant ( ? )
    p10 411 ±210 μs 462 ±236 μs +51.1 μs (+12.4%) NO
    p25 422 ±213 μs 480 ±239 μs +57.9 μs (+13.7%) NO
    p50 441 ±217 μs 510 ±236 μs +69.0 μs (+15.6%) NO
    p75 502 ±212 μs 594 ±229 μs +92.5 μs (+18.4%) NO
    p90 577 ±196 μs 694 ±260 μs +116 μs (+20.2%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz
    redfin-30
    Percentile 6c3fc22 55337e3 Diff Significant ( ? )
    p10 757 ±248 μs 655 ±175 μs -102 μs (-13.5%) NO
    p25 773 ±247 μs 669 ±177 μs -104 μs (-13.4%) NO
    p50 797 ±243 μs 693 ±179 μs -105 μs (-13.1%) NO
    p75 832 ±236 μs 732 ±188 μs -99.6 μs (-12.0%) NO
    p90 879 ±232 μs 859 ±389 μs -20.0 μs (-2.3%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz

  • timeToInitialDisplay

    Device Statistics Distributions
    oriole-32
    Percentile 6c3fc22 55337e3 Diff Significant ( ? )
    p10 198 ±2 ms 205 ±4 ms +6.52 ms (+3.3%) NO
    p25 204 ±2 ms 210 ±4 ms +6.50 ms (+3.2%) NO
    p50 211 ±3 ms 218 ±4 ms +6.38 ms (+3.0%) NO
    p75 219 ±3 ms 226 ±5 ms +7.79 ms (+3.6%) NO
    p90 228 ±4 ms 238 ±9 ms +10.5 ms (+4.6%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz
    redfin-30
    Percentile 6c3fc22 55337e3 Diff Significant ( ? )
    p10 247 ±3 ms 270 ±7 ms +23.0 ms (+9.3%) MAYBE
    p25 253 ±3 ms 275 ±8 ms +22.3 ms (+8.8%) MAYBE
    p50 259 ±4 ms 283 ±8 ms +23.7 ms (+9.2%) MAYBE
    p75 266 ±4 ms 292 ±9 ms +26.0 ms (+9.8%) MAYBE
    p90 274 ±5 ms 302 ±12 ms +28.9 ms (+10.6%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C5x0fPalX8/index.html

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
@wu-hui @google-oss-bot
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close