•  


Updated libcrashlytics to be compatible with 16K devices by mrober · Pull Request #5785 · firebase/firebase-android-sdk · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated libcrashlytics to be compatible with 16K devices #5785

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated libcrashlytics to be compatible with 16K devices #5785

wants to merge 2 commits into from

Conversation

mrober
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-crashlytics-ndk 
### 
{{crashlytics}} NDK version 18.6.4 {: #crashlytics-ndk_v18-6-4}


*
 {{changed}} Updated libcrashlytics to be compatible with 16K devices

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2024 •
edited

Coverage Report 1

Affected Products

No changes between base commit ( 6c3fc22 ) and merge commit ( ebccd54 ).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q7JqpeITTg.html

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

0 files? ?-??????948??0 suites? ?-?948???0s ?? - 33m 13s
0 tests ?-???5?211??0 ?? ?-???5?190??0 ?? ?-?21??0 ? ±0?
0 runs? ?-?10?507??0 ?? ?-?10?465??0 ?? ?-?42??0 ? ±0?

Results for commit 7fe5981 .?± Comparison against base commit 5a06c26 .

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2024 •
edited

Size Report 1

Affected Products

  • firebase-crashlytics-ndk

    Type Base ( 6c3fc22 ) Merge ( ebccd54 ) Diff
    aar 1.66 MB 1.65 MB -269 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wdxJNp8iAR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2024 •
edited

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    Device Statistics Distributions
    oriole-32
    Percentile 6c3fc22 ebccd54 Diff Significant ( ? )
    p10 10.6 ±2 ms 10.7 ±3 ms +133 μs (+1.3%) NO
    p25 11.3 ±2 ms 11.4 ±3 ms +163 μs (+1.4%) NO
    p50 12.2 ±3 ms 12.5 ±3 ms +279 μs (+2.3%) NO
    p75 13.4 ±3 ms 14.2 ±3 ms +752 μs (+5.6%) NO
    p90 15.3 ±3 ms 16.0 ±4 ms +664 μs (+4.3%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    ebccd54
    • 2024-04-02_20:12:10.149155_VOai
    • 2024-04-02_20:12:10.149187_RzOL
    • 2024-04-02_20:12:10.149195_NXkb
    • 2024-04-02_20:12:10.149199_iBSL
    • 2024-04-02_20:12:10.149203_tcCe
    • 2024-04-02_20:12:10.149207_bRSk
    • 2024-04-02_20:12:10.149211_AtOS
    • 2024-04-02_20:12:10.149217_MTrW
    • 2024-04-02_20:12:10.149226_Skti
    • 2024-04-02_20:12:10.149235_OwDb
    redfin-30
    Percentile 6c3fc22 ebccd54 Diff Significant ( ? )
    p10 13.8 ±5 ms 13.1 ±3 ms -678 μs (-4.9%) NO
    p25 14.4 ±5 ms 13.8 ±4 ms -600 μs (-4.2%) NO
    p50 15.2 ±6 ms 14.7 ±4 ms -475 μs (-3.1%) NO
    p75 16.3 ±6 ms 15.9 ±5 ms -436 μs (-2.7%) NO
    p90 17.6 ±7 ms 17.7 ±5 ms +79.2 μs (+0.4%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    ebccd54
    • 2024-04-02_20:12:10.149155_VOai
    • 2024-04-02_20:12:10.149187_RzOL
    • 2024-04-02_20:12:10.149195_NXkb
    • 2024-04-02_20:12:10.149199_iBSL
    • 2024-04-02_20:12:10.149203_tcCe
    • 2024-04-02_20:12:10.149207_bRSk
    • 2024-04-02_20:12:10.149211_AtOS
    • 2024-04-02_20:12:10.149217_MTrW
    • 2024-04-02_20:12:10.149226_Skti
    • 2024-04-02_20:12:10.149235_OwDb

  • timeToInitialDisplay

    Device Statistics Distributions
    oriole-32
    Percentile 6c3fc22 ebccd54 Diff Significant ( ? )
    p10 198 ±2 ms 205 ±3 ms +6.34 ms (+3.2%) NO
    p25 204 ±2 ms 211 ±4 ms +6.62 ms (+3.2%) NO
    p50 211 ±3 ms 218 ±6 ms +6.62 ms (+3.1%) NO
    p75 219 ±3 ms 225 ±6 ms +6.66 ms (+3.0%) NO
    p90 228 ±4 ms 236 ±8 ms +8.74 ms (+3.8%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    ebccd54
    • 2024-04-02_20:12:10.149155_VOai
    • 2024-04-02_20:12:10.149187_RzOL
    • 2024-04-02_20:12:10.149195_NXkb
    • 2024-04-02_20:12:10.149199_iBSL
    • 2024-04-02_20:12:10.149203_tcCe
    • 2024-04-02_20:12:10.149207_bRSk
    • 2024-04-02_20:12:10.149211_AtOS
    • 2024-04-02_20:12:10.149217_MTrW
    • 2024-04-02_20:12:10.149226_Skti
    • 2024-04-02_20:12:10.149235_OwDb
    redfin-30
    Percentile 6c3fc22 ebccd54 Diff Significant ( ? )
    p10 247 ±3 ms 268 ±6 ms +21.4 ms (+8.7%) MAYBE
    p25 253 ±3 ms 274 ±5 ms +21.2 ms (+8.4%) MAYBE
    p50 259 ±4 ms 281 ±6 ms +21.8 ms (+8.4%) MAYBE
    p75 266 ±4 ms 290 ±7 ms +24.1 ms (+9.1%) MAYBE
    p90 274 ±5 ms 303 ±11 ms +29.2 ms (+10.7%) NO

    20 test runs in comparison
    Commit Test Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    ebccd54
    • 2024-04-02_20:12:10.149155_VOai
    • 2024-04-02_20:12:10.149187_RzOL
    • 2024-04-02_20:12:10.149195_NXkb
    • 2024-04-02_20:12:10.149199_iBSL
    • 2024-04-02_20:12:10.149203_tcCe
    • 2024-04-02_20:12:10.149207_bRSk
    • 2024-04-02_20:12:10.149211_AtOS
    • 2024-04-02_20:12:10.149217_MTrW
    • 2024-04-02_20:12:10.149226_Skti
    • 2024-04-02_20:12:10.149235_OwDb

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HSe88aknbw/index.html

jrothfeder
jrothfeder approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@jrothfeder jrothfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

well, that was easy :)

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@kmandrika kmandrika Awaiting requested review from kmandrika

Assignees
No one assigned
Labels
main-merge-ack size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@mrober @google-oss-bot @jrothfeder
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close