Project for the Wikimedia Commons community.
The intention behind this project is:
See also Commons:Bugs IRC: #wikimedia-commons-tech
Please do not report tasks under this project if the task is not actually specific to Commons but only because you found this problem on Commons. Also see How to report a bug .
(For the records: The creation of this project was discussed in T39883 and T802 .)
See also:
In T353981#9801657 , @Bawolff wrote: I think IFD1 is for the embedded thumbnail (if present) and not the actual image. (ifd1 is irrelavent) I guess we could have the riff tags override, thry would be source of truth. Its a little weird we extract the technical data from exif at all.
I think IFD1 is for the embedded thumbnail (if present) and not the actual image. (ifd1 is irrelavent)
I guess we could have the riff tags override, thry would be source of truth.
Its a little weird we extract the technical data from exif at all.
I think IFD1 is for the embedded thumbnail (if present) and not the actual image.
exiftool -a -u -g1 /Users/djhartman/Downloads/Xili_Eco_Park.webp ---- ExifTool ---- ExifTool Version Number : 12.76 ---- System ---- File Name : Xili_Eco_Park.webp Directory : /Users/djhartman/Downloads File Size : 18 MB File Modification Date/Time : 2024:05:15 14:04:27+02:00 File Access Date/Time : 2024:05:15 14:04:30+02:00 File Inode Change Date/Time : 2024:05:15 14:04:27+02:00 File Permissions : -rw-r--r-- ---- File ---- File Type : Extended WEBP File Type Extension : webp MIME Type : image/webp Exif Byte Order : Big-endian (Motorola, MM) ---- RIFF ---- WebP Flags : XMP, EXIF Image Width : 4096 Image Height : 3072 Image Width : 4096 Image Height : 3072 ---- IFD0 ---- Y Resolution : 72 X Resolution : 72 Image Width : 0 Image Height : 0 Orientation : Horizontal (normal) Resolution Unit : inches Modify Date : 2023:11:25 20:54:21 ---- ExifIFD ---- Color Space : Uncalibrated Exif Image Width : 4096 Exif Image Height : 3072 Light Source : Unknown ---- IFD1 ---- Y Resolution : 72 Compression : JPEG (old-style) X Resolution : 72 Resolution Unit : inches ---- XMP-x ---- XMP Toolkit : Adobe XMP Core 6.0-c003 116.ddc7bc4, 2021/08/17-13:18:37 ---- XMP-xmp ---- Creator Tool : Adobe Photoshop 21.2 (Windows) Create Date : 2023:09:30 21:25:39+08:00 Modify Date : 2023:11:25 20:54:21+08:00 Metadata Date : 2023:11:25 20:54:21+08:00 ---- XMP-dc ---- Format : application/vnd.adobe.photoshop ---- XMP-photoshop ---- Color Mode : RGB ---- XMP-xmpMM ---- Instance ID : xmp.iid:5b650ae8-c3a2-7e43-9a51-142fa1b50708 Document ID : xmp.did:5b650ae8-c3a2-7e43-9a51-142fa1b50708 Original Document ID : xmp.did:5b650ae8-c3a2-7e43-9a51-142fa1b50708 History Action : created History Instance ID : xmp.iid:5b650ae8-c3a2-7e43-9a51-142fa1b50708 History When : 2023:09:30 21:25:39+08:00 History Software Agent : Adobe Photoshop 21.2 (Windows) ---- XMP-tiff ---- Orientation : Horizontal (normal) X Resolution : 72 Y Resolution : 72 Resolution Unit : inches ---- XMP-exif ---- Color Space : Uncalibrated Exif Image Width : 4096 Exif Image Height : 3072 ---- Composite ---- Image Size : 4096x3072 Megapixels : 12.6
This image seems better: https://commons.wikimedia.org/wiki/File:Xili_Eco_Park.webp Clash of exif and xmp perhaps ?
Hmm, something doesn't seem quite right yet.
@Mike_Peel I fixed the template with this change: https://commons.m.wikimedia.org/w/index.php?title=MediaWiki:Minerva.css&diff=876480738&oldid=876480698&title=MediaWiki%3AMinerva.css&diffonly=1
It's not. It's also not the first time WMF has added hack stylesheets; the original was for adapting some templates to be more friendly for mobile. (They came to understand that these hacks were not generally a good thing.) Now they live in WikimediaMessages , though they used to live in the Minerva skin.
"hack stylesheet" - can you be more specific? That doesn't sound good for the long term.
On enwiki, there is also a defined background-color for .infobox in https://en.wikipedia.org/wiki/MediaWiki:Common.css - but that seems to be OK?
WMF has added a hack stylesheet which takes care of many of the common user-created classes that one might encounter. That is why .infobox is fine.
We don't have as many webp files (26,729) as we have jpgs/pngs (92 million total), so I don't think it is a problem in this case. Does remind me that we should add an example to the ticket, for the person executing it to check the result.
See also the very old T32961
It doesn't seem we have had a lot of complaints about this. Also "some files" isn't really specific information to go on 9 years later..
This process is now managed at https://commons.wikimedia.org/wiki/MediaWiki_talk:Copyupload-allowed-domains , not Phabricator.
For thumbor, the logic is here: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/thumbor-plugins/+/refs/heads/master/wikimedia_thumbor/engine/imagemagick/imagemagick.py#443
Change #1030610 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/core@master] [DNM] Add support for exif orientations that flip
https://gerrit.wikimedia.org/r/1030610
Change #1030530 merged by jenkins-bot:
[mediawiki/core@master] Add exif/xmp reading for webp to releasenotes
https://gerrit.wikimedia.org/r/1030530
Change #1030530 had a related patch set uploaded (by TheDJ; author: TheDJ):
Thanks brian. I was so close before, can't believe I didn't think of mixing the tiff parser with the stripping of the exif\0\0. Good idea to check the exiftool parser.
Change #1030525 merged by jenkins-bot:
[mediawiki/core@master] Extract XMP & Exif from WebP files
https://gerrit.wikimedia.org/r/1030525