•  


fix(security): do not allow to read files above by alexander-akait · Pull Request #1779 · webpack/webpack-dev-middleware · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): do not allow to read files above #1779

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix(security): do not allow to read files above #1779

merged 1 commit into from
Mar 20, 2024

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

security fix

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait merged commit 189c4ac into version-5 Mar 20, 2024
1 check passed
@alexander-akait alexander-akait deleted the fix-security branch March 20, 2024 15:15
@Omrisnyk Omrisnyk mentioned this pull request Mar 22, 2024
Open
@justinclift justinclift mentioned this pull request Mar 24, 2024
Merged
megagreg72
megagreg72 reviewed Mar 25, 2024
View reviewed changes
src/utils/getFilenameFromUrl.js
Comment on lines +131 to +134
// ".." is malicious
if (UP_PATH_REGEXP.test(path.normalize(`./${pathname}`))) {
// eslint-disable-next-line no-param-reassign
extra.errorCode = 403;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

This is the key change, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

yes

@jkeys089
Copy link

@alexander-akait is there any plan to backport this fix to v4? We have a project still on Nuxt 2 / Webpack 4.

@alexander-akait
Copy link
Member Author

@jkeys089 Webpack 4 is deprecated, so if you want to do it, feel free to send a PR and I will make a release

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@megagreg72 megagreg72 megagreg72 left review comments

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@alexander-akait @jkeys089 @megagreg72
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close