•  


Go back using xmlhttprequest for bidi-streams by wu-hui · Pull Request #8197 · firebase/firebase-js-sdk · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go back using xmlhttprequest for bidi-streams #8197

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Go back using xmlhttprequest for bidi-streams #8197

merged 2 commits into from
Apr 24, 2024

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 22, 2024 •
edited by MarkDuckworth

Go back using xmlhttprequest for bidi-streams, as fetch streams seem to be having connection issue.

@wu-hui wu-hui requested review from a team as code owners April 22, 2024 18:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024 •
edited

?? Changeset detected

Latest commit: 97f457a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are .

Click here if you're a maintainer who wants to add another changeset to this PR

@wu-hui wu-hui requested a review from a team as a code owner April 22, 2024 18:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024 •
edited

Size Report 1

Affected Products

  • @firebase/firestore

    Type Base ( 03069bb ) Merge ( 402b93d ) Diff
    browser 377 kB 377 kB +47 B (+0.0%)
    esm5 362 kB 362 kB +47 B (+0.0%)
    module 377 kB 377 kB +47 B (+0.0%)
    react-native 377 kB 377 kB +47 B (+0.0%)

  • bundle

    Type Base ( 03069bb ) Merge ( 402b93d ) Diff
    firestore (CSI Auto Indexing Disable and Delete) 269 kB 269 kB +17 B (+0.0%)
    firestore (CSI Auto Indexing Enable) 269 kB 269 kB +17 B (+0.0%)
    firestore (Persistence) 303 kB 303 kB +17 B (+0.0%)
    firestore (Query Cursors) 241 kB 241 kB +17 B (+0.0%)
    firestore (Query) 238 kB 238 kB +17 B (+0.0%)
    firestore (Read data once) 226 kB 226 kB +17 B (+0.0%)
    firestore (Read Write w Persistence) 323 kB 323 kB +17 B (+0.0%)
    firestore (Realtime updates) 229 kB 229 kB +17 B (+0.0%)
    firestore (Transaction) 205 kB 205 kB +17 B (+0.0%)
    firestore (Write data) 205 kB 205 kB +17 B (+0.0%)

  • firebase

    Type Base ( 03069bb ) Merge ( 402b93d ) Diff
    firebase-compat.js 786 kB 786 kB +13 B (+0.0%)
    firebase-firestore-compat.js 342 kB 342 kB +13 B (+0.0%)
    firebase-firestore.js 436 kB 436 kB -15 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wWnbbfLz3A.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024 •
edited

Size Analysis Report 1

This report is too large (136,860 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xgfRtQcad4.html

MarkDuckworth
MarkDuckworth approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

LGTM, but I want to hold this until the release staging deadline, while we investigate alternative fixes.

@wu-hui wu-hui merged commit e1a7764 into master Apr 24, 2024
44 checks passed
@wu-hui wu-hui deleted the wuandy/XmlHttpAgain branch April 24, 2024 13:23
@google-oss-bot google-oss-bot mentioned this pull request Apr 24, 2024
Merged
@firebase firebase locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub . Already have an account? Sign in .
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@wu-hui @google-oss-bot @MarkDuckworth
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close