•  


feat(auth): Add Email Privacy support in Project and Tenant config by pragatimodi · Pull Request #2198 · firebase/firebase-admin-node · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Add Email Privacy support in Project and Tenant config #2198

Merged
merged 16 commits into from
Sep 7, 2023
Merged

feat(auth): Add Email Privacy support in Project and Tenant config #2198

merged 16 commits into from
Sep 7, 2023

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented May 28, 2023 •
edited by lahirumaramba

RELEASE NOTE: Added email privacy support in project and tenant configuration

@pragatimodi pragatimodi marked this pull request as ready for review June 5, 2023 16:35
Xiaoshouzi-gh
Xiaoshouzi-gh requested changes Jun 6, 2023
View reviewed changes
src/auth/tenant.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Show resolved Hide resolved
test/integration/auth.spec.ts Show resolved Hide resolved
kevinthecheung
kevinthecheung approved these changes Jun 7, 2023
View reviewed changes
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
@pragatimodi @kevinthecheung
Apply suggestions from code review
d885be7 
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@lahirumaramba lahirumaramba added release:stage Stage a release candidate release-note labels Aug 18, 2023
lahirumaramba
lahirumaramba approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Thanks! Please get the docs reviewed by a TW before merging
Just noticed Kevin's reviews. Thanks

@pragatimodi
Copy link
Contributor Author

Hey @lahirumaramba , looks like the remoteConfig integration tests are failing. But they aren't related to this change, should we go ahead and merge this PR then?

@pragatimodi pragatimodi merged commit a4019e4 into master Sep 7, 2023
7 checks passed
@lahirumaramba lahirumaramba deleted the email-privacy branch September 26, 2023 20:05
@roblo1801 roblo1801 mentioned this pull request May 17, 2024
Open
@CalHoll CalHoll mentioned this pull request May 29, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 11, 2024
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@renkelvin renkelvin renkelvin approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

Assignees
No one assigned
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
@pragatimodi @lahirumaramba @renkelvin @kevinthecheung @Xiaoshouzi-gh
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close