•  


4029: Add debug flag for delr page empty trace by LivingLimes · Pull Request #4068 · surrealdb/surrealdb · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4029: Add debug flag for delr page empty trace #4068

Conversation

LivingLimes
Copy link
Contributor

@LivingLimes LivingLimes commented May 19, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Hide unwanted trace from release build to minimise logging noise.

What does this change do?

Hide unwanted trace from release build using debug flag.

What is your testing strategy?

Tested manually via the following steps:

  1. Start app with in memory db in release mode:
cargo watch -x 
'
run --no-default-features --features storage-mem,http,scripting --release -- start --log trace --user root --pass root memory
'
  1. Import data into the in memory db (this is required so that there are things for the db to garbage collect, else the function that calls this trace will not appear). I used the first 100 lines from the demo data .
cargo run -- import --conn http://localhost:8000 --user root --pass root --ns 
test
 --db 
test
 ~
/Downloads/surreal-deal-v2.surql
  1. Observe traces
    Without the code change:
( tv_sec 221093, tv_nsec 488276916

With the code change:
image

(I added a trace _delr called to be sure the function was being called.)

Is this related to any issues?

Closes #4029

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

Have you read the Contributing Guidelines?

@LivingLimes LivingLimes marked this pull request as ready for review May 20, 2024 07:40
@LivingLimes LivingLimes requested a review from a team as a code owner May 20, 2024 07:40
@phughk
Copy link
Contributor

Thanks for fixing this :) Looking for next ticket

@phughk phughk enabled auto-merge May 21, 2024 12:55
@phughk phughk added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@tobiemh tobiemh added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@phughk phughk added this pull request to the merge queue May 21, 2024
Merged via the queue into surrealdb : main with commit 140e709 May 21, 2024
22 checks passed
@LivingLimes LivingLimes deleted the bugfix-4029-remove-delr-from-release-trace branch May 22, 2024 01:40
@rushmorem rushmorem added this to the v2.0.0-alpha.1 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Delr is displayed in trace logs of releases
4 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본