•  


Doesn't correctly handle T types. · Issue #222 · rhys-vdw/ts-auto-guard · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't correctly handle T types. #222

Open
ToborWinner opened this issue Dec 28, 2022 · 2 comments
Open

Doesn't correctly handle T types. #222

ToborWinner opened this issue Dec 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ToborWinner
Copy link

This code seems to cause issues, I had to manually fix my guard check.

export
 interface
 BaseVideo
<
T
 extends
 VideoType
 =
 VideoType
>
 {

    type
: 
T
;

    data
: 
T
 extends
 "MOTIVATIONAL"
 ? 
MotivationalVideoData
 :
        
T
 extends
 "SHOWER_THOUGHTS"
 ? 
ShowerThoughtsVideoData
 :
        
T
 extends
 "QUIZ"
 ? 
QuizVideoData
 :
        
T
 extends
 "QUIZ_SHORT"
 ? 
QuizShortVideoData
 :
        
T
 extends
 "SUMMARY"
 ? 
any
 : 
never
;

}

(Yes isVideoType is included in the guards, and the other types not included in this code too)

Apart the data part, which is understandable if it gets it wrong, the guard checks if the type is equal to "T" and typescript gives me an error there.

@download13
Copy link
Collaborator

It looks like you're trying to make a discriminated union , that looks like a java base type ?

type
 Video
 =

  |
 MotivationalVideo

  |
 ShowerThoughtsVideo

  ...

type
 MotivationalVideo
 =
 {

  type
: 
'MOTIVATIONAL'

  data
: 
MotivationalVideoData

}


type
 ShowerThoughtsVideo
 =
 {

  type
: 
'SHOWER_THOUGHTS'

  data
: 
ShowerThoughtsVideoData

}


...

If it's possible to use that pattern in your codebase, you can likely generate guards for the constituent types and the union.

@rhys-vdw rhys-vdw added the enhancement New feature or request label Jan 4, 2023
@rhys-vdw
Copy link
Owner

Please provide expected output.

Although you should know that whatever it is, it's extremely unlikely to be easy to support.

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본