•  


Type-only imports · Issue #166 · rhys-vdw/ts-auto-guard · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-only imports #166

Open
mjarr opened this issue Jan 4, 2022 · 3 comments · May be fixed by #210
Open

Type-only imports #166

mjarr opened this issue Jan 4, 2022 · 3 comments · May be fixed by #210
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mjarr
Copy link

Currently .guard.ts files import needed types using normal imports, which results in ts(1371) and ts(1444) errors in my environment (svelte). Making the imports type-only would solve this issue.

@rhys-vdw
Copy link
Owner

I hadn't heard of this feature. Would this change the minimum TypeScript version?

@rhys-vdw rhys-vdw added the enhancement New feature or request label Jan 5, 2022
@mjarr
Copy link
Author

They were introduced in TypeScript 3.8 .
Seems like all that needs to be done to enable them is to add isTypeOnly: true to objects pushed to structures in outFile.addImportDeclarations .

@rhys-vdw
Copy link
Owner

Okay cool, I think it's reasonably to upgrade the minimum version to 3.8. Note that this would not always be appropriate due to the way that classes are checked. See discussion in #162 .

@rhys-vdw rhys-vdw added the good first issue Good for newcomers label Jan 7, 2022
@download13 download13 linked a pull request Oct 13, 2022 that will close this issue
Open
@download13 download13 mentioned this issue Nov 12, 2022
Merged
@download13 download13 mentioned this issue Nov 20, 2022
Open
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type only imports 166 download13/ts-auto-guard
2 participants
@rhys-vdw @mjarr
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close