•  


Typescript Hygiene and curated exports · Issue #3925 · recharts/recharts · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Hygiene and curated exports #3925

Open
nikolasrieble opened this issue Nov 1, 2023 · 5 comments
Open

Typescript Hygiene and curated exports #3925

nikolasrieble opened this issue Nov 1, 2023 · 5 comments
Labels
typescript PRs or Issues surrounding Types or TS refactoring

Comments

@nikolasrieble
Copy link
Contributor

nikolasrieble commented Nov 1, 2023

Acceptance criteria:

@charpeni
Copy link
Contributor

Already mentioned, but wanted to +1 on getting rid of the any disease.

Additionally, turning on strict mode could be really interesting to better take advantage of TypeScript.

@ckifer ckifer added the typescript PRs or Issues surrounding Types or TS refactoring label Nov 2, 2023
@ckifer
Copy link
Member

No any in the repo - neither explicit nor implicit

So I completely agree, but there are certainly some places where it is much more of a concern than others. For example, anything that the user provides (their data, their dataKey, their custom stuff) is less important to type correctly than the things we provide users (callback functions, payloads, props we actually so stuff with).

+1 for getting to a point where we can turn on strict mode.

@csdiehl
Copy link
Contributor

@nikolasrieble happy to take this on if no one else has already

@ckifer
Copy link
Member

@csdiehl this one will be harder to tackle than it looks on the surface. The codebase is littered with bad types and if we change those bad types we'll break how consumers are currently using them. If you want to try to do this we either need to

  1. Ensure non-breaking changes
    Or
  2. Do this as if it would go into 3.x.

Type changes are hard to make non-breaking so 2 would be easier. 3.x will have a lot of other changes though and that will make huge merge conflicts for this. We may be better off making types better after refactoring than doing it now. Or do it in a non-breaking way

@csdiehl
Copy link
Contributor

ok - @ckifer since I'm new to contributing to this project, I'll look for smaller issues to tackle first. Someone else can take this

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
typescript PRs or Issues surrounding Types or TS refactoring
Projects
Status: No status
Development

No branches or pull requests

4 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본