•  


Remove severity as a baseline key, as it interacts poorly with `--strict` by mildm8nnered · Pull Request #5566 · realm/SwiftLint · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove severity as a baseline key, as it interacts poorly with --strict #5566

Conversation

mildm8nnered
Copy link
Collaborator

I've been dogfooding baselines, and there's an unfortunate interaction with --strict , because we use severity as part of the key for determining which violations are new.

The original idea behind including severity was that if some violations are warnings, and they suddenly become errors, then maybe you would want to know about that.

But of course, with --strict , all warning become errors, but you probably don't want to get alerted to thousands of violations.

My use case was danger , where I have swiftlint.lint_files inline_mode: true, fail_on_error: true, additional_swiftlint_args: '--strict' in my dangerfile

@SwiftLintBot
Copy link

1 Warning
?? If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md .
17 Messages
?? Linting Aerial with this PR took 0.81s vs 0.81s on main (0% slower)
?? Linting Alamofire with this PR took 1.13s vs 1.18s on main (4% faster)
?? Linting Brave with this PR took 6.61s vs 6.59s on main (0% slower)
?? Linting DuckDuckGo with this PR took 3.57s vs 3.51s on main (1% slower)
?? Linting Firefox with this PR took 9.36s vs 9.32s on main (0% slower)
?? Linting Kickstarter with this PR took 8.17s vs 8.04s on main (1% slower)
?? Linting Moya with this PR took 0.51s vs 0.51s on main (0% slower)
?? Linting NetNewsWire with this PR took 2.38s vs 2.35s on main (1% slower)
?? Linting Nimble with this PR took 0.7s vs 0.69s on main (1% slower)
?? Linting PocketCasts with this PR took 6.92s vs 6.89s on main (0% slower)
?? Linting Quick with this PR took 0.33s vs 0.34s on main (2% faster)
?? Linting Realm with this PR took 4.0s vs 4.02s on main (0% faster)
?? Linting Sourcery with this PR took 2.1s vs 2.06s on main (1% slower)
?? Linting Swift with this PR took 3.88s vs 3.89s on main (0% faster)
?? Linting VLC with this PR took 1.13s vs 1.16s on main (2% faster)
?? Linting Wire with this PR took 14.28s vs 14.3s on main (0% faster)
?? Linting WordPress with this PR took 9.73s vs 9.64s on main (0% slower)

Here's an example of your CHANGELOG entry:

*
 Remove severity as a baseline key, as it interacts poorly with 
`
--strict
`
.  
  
[
mildm8nnered
]
(
https://github.com/mildm8nnered
)

  [
#issue_number
]
(
https://github.com/realm/SwiftLint/issues/issue_number
)

note : There are two invisible spaces after the entry's text.

Generated by ?? Danger

@mildm8nnered mildm8nnered marked this pull request as ready for review May 10, 2024 23:20
@mildm8nnered
Copy link
Collaborator Author

Not strictly user facing, and the baseline file format is unchanged, so I don't think this needs a changelog entry.

@SimplyDanny SimplyDanny merged commit b17bbaa into realm : main May 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본