fetch support #230

xg-wang · 2018-05-23T01:05:33Z

tl;dr

This commit adds support for fetch, fix Using Pretender with fetch. ?#60 .
pretender swap native fetch related API if exists
pretender.shutdown() restore native fetch related API
doesn't work with AbortController

Changes

Include a fetch ponyfill and swap the native fetch during pretender
creation, then restore them when shutdown. Since fetch polyfill uses
xhr behind the scene, pretender should "just work".

Caveats

The supplement set of the polyfill implementation with the spec includes (not complete):

Inability to set the redirect mode
Inability to change the cache directive
Inability to disable same-origin cookies

~~Abort~~ Update: Fixed by Enable Abortable fetch ?#234

xhr.abort() first set state to done, finally response to a
network error ;
fetch will reject promise with a new "AbortError" DOMException.

As implemented in fake_xml_http_request, the request is resolved once its
state is changed to DONE.
So the scenario happens in pretender is:
1). state changes to DONE, trigger resolve request
2). abort, trigger reject
3). xhr.onerror, trigger reject
The first resolve wins, error thus not rejected but an empty request is resolved.

Though polyfilled by xhr, fetch returns a Promise and is asynchronous by
nature.
No streaming Streaming support ?JakeChampion/fetch#198

tl;dr - This commit adds support for fetch, fix pretenderjs#60 . - pretender swap native fetch related API if exists - pretender.shutdown() restore native fetch related API - doesn't work with AbortController Changes ------ Include a fetch ponyfill and swap the native fetch during pretender creation, then restore them when `shutdown`. Since fetch polyfill uses xhr behind the scene, pretender should "just work". Caveats ------ 1. The supplement set of yetch impl and spec includes (not complete): - Inability to [set the redirect mode]( JakeChampion/fetch#137 ) - Inability to [change the cache directive]( JakeChampion/fetch#438 (comment) ) - Inability to [disable same-origin cookies]( JakeChampion/fetch#56 (comment) ) 2. Abort - `xhr.abort()` first set state to done, finally response to a [network error]( https://xhr.spec.whatwg.org/#the-abort()-method ); - [fetch]( https://dom.spec.whatwg.org/#aborting-ongoing-activities ) will reject promise with a new "AbortError" DOMException. As implemented in `fake_xml_http_request`, the request is resolved once its state is changed to `DONE`. So the scenario happens in pretender is: 1). state changes to `DONE`, trigger resolve request 2). abort, trigger reject 3). xhr.onerror, trigger reject The first resolve wins, error thus not rejected but an empty request is resolved. 3. Though polyfilled by xhr, fetch returns a Promise and is asynchronous by nature.

xg-wang · 2018-05-23T01:26:11Z

Yetch doesn't provide a ponyfill now, include the file temporarily.
Netflix/yetch#5

Github/fetch has merged PR for UMD distribution: JakeChampion/fetch#616 Also abort support has been added: JakeChampion/fetch#592 We can use Github fetch instead of yetch now. But AbortableFetch is still not supported, see comment in test.

remove yetch, use FakeFetch to reference WHATWGFetch

xg-wang · 2018-05-24T20:43:01Z

I released a fork version to have umd available, @xg-wang/whatwg-fetch need to be removed once official release is out.

billymoon · 2018-07-12T19:46:11Z

Any updates on this PR? I am super keen to consume fetch-pretender or ideally, pretender from a cdn like http://cdn.jsdelivr.net/npm/pretender .

xg-wang · 2018-07-14T05:50:47Z

CI error:
bower EINVRES Request to https://bower.herokuapp.com/packages/FakeXMLHttpRequest failed with 502
~~likely to be fixed by restarting~~
Fixed by upgrading bower to 1.8.2

bower is migrating registry away from heroku after v1.8.2 https://github.com/bower/bower/releases/tag/v1.8.2

xg-wang · 2018-07-16T16:35:26Z

This is ready now. Need review @stefanpenner @rwjblue

stefanpenner · 2018-07-16T18:47:32Z

test/fetch_test.js

+      false
+    );
+
+    fetch('/some/path').then(function() {


This is async, so this needs to block

if this is qunit lets use the async promise assert helpers

stefanpenner · 2018-07-16T18:48:12Z

test/fetch_test.js

+    setTimeout(function() {
+      controller.abort();
+    }, 10);
+    fetch('/downloads', { signal: signal })


if this is qunit lets use the async promise assert helpers

stefanpenner · 2018-07-16T18:49:11Z

Oops, I merged this prematurely. @xg-wang can you address the above two comments today? If not, i'll have to revert until addressed.

add ponyfill

26b42fc

xg-wang force-pushed the feat/fetch branch from eb9434a to 26b42fc Compare May 23, 2018 01:44

Thomas Wang added 2 commits May 24, 2018 13:31

switch to github fetch

a0bb51f

Github/fetch has merged PR for UMD distribution: JakeChampion/fetch#616 Also abort support has been added: JakeChampion/fetch#592 We can use Github fetch instead of yetch now. But AbortableFetch is still not supported, see comment in test.

cleanup

d12c7f9

remove yetch, use FakeFetch to reference WHATWGFetch

xg-wang mentioned this pull request May 29, 2018

use browser fetch if exists ember-cli/ember-fetch#63

Merged

Use forked whatwg-fetch to enable umd

6e5fcd2

xg-wang mentioned this pull request Jul 14, 2018

Update dependencies rwjblue/ember-cli-pretender#62

Merged

Thomas Wang added 2 commits July 14, 2018 21:33

Update bower to fix CI

6431b09

bower is migrating registry away from heroku after v1.8.2 https://github.com/bower/bower/releases/tag/v1.8.2

update comment and changelog

9ccacb4

stefanpenner merged commit 3646491 into pretenderjs : master Jul 16, 2018

stefanpenner reviewed Jul 16, 2018

View reviewed changes

xg-wang mentioned this pull request Jul 16, 2018

update test dep, fix async test for fetch #231

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fetch support #230

fetch support #230

xg-wang commented May 23, 2018 •

edited

xg-wang commented May 23, 2018 •

edited

xg-wang commented May 24, 2018 •

edited

billymoon commented Jul 12, 2018 •

edited

xg-wang commented Jul 14, 2018 •

edited

xg-wang commented Jul 16, 2018

stefanpenner Jul 16, 2018

stefanpenner Jul 16, 2018

stefanpenner Jul 16, 2018

stefanpenner commented Jul 16, 2018

fetch support #230

fetch support #230

Conversation

xg-wang commented May 23, 2018 • edited

Changes

Caveats

xg-wang commented May 23, 2018 • edited

xg-wang commented May 24, 2018 • edited

billymoon commented Jul 12, 2018 • edited

xg-wang commented Jul 14, 2018 • edited

xg-wang commented Jul 16, 2018

stefanpenner Jul 16, 2018

Choose a reason for hiding this comment

stefanpenner Jul 16, 2018

Choose a reason for hiding this comment

stefanpenner Jul 16, 2018

Choose a reason for hiding this comment

stefanpenner commented Jul 16, 2018

xg-wang commented May 23, 2018 •

edited

xg-wang commented May 23, 2018 •

edited

xg-wang commented May 24, 2018 •

edited

billymoon commented Jul 12, 2018 •

edited

xg-wang commented Jul 14, 2018 •

edited