•  


Fix: Multiline `Text` though clipped can be scrolled into view by tienifr · Pull Request #2584 · necolas/react-native-web · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multiline Text though clipped can be scrolled into view #2584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Multiline Text though clipped can be scrolled into view #2584

wants to merge 1 commit into from
+1 ?1

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Sep 25, 2023 •
edited

Details

Fixes #2582 .

On mobile Web, multiline Text 's clipped part can be scrolled into view by dragging selection cursor. This PR blocks scrolling entirely, through any mechanism, over overflown text.

Tests

  1. Create a long Text with numberOfLines > 1
  2. On mWeb, long press the text to toggle text selection cursor
  3. Drag the selection cursor vertically
  4. Observe that the clipped text cannot be scrolled into view

Screenshots/Videos

Screenrecording_20230925_183054.mp4

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox .

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9224e34 :

Sandbox Source
react-native-web-examples Configuration

@tienifr tienifr mentioned this pull request Sep 27, 2023
Open
6 tasks
@roryabraham roryabraham mentioned this pull request Dec 9, 2023
Open
@neil-marcellini
Copy link

@necolas could you please take a look at this or get someone to review it for us please?

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mWeb - Multiline Text 's clipped part is scrolled into view by dragging selection cursor
2 participants
@tienifr @neil-marcellini
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close