•  


Make ytd_hook.lua's ytdl binary file path and the ytdl json output available to other scripts · Issue #14097 · mpv-player/mpv · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ytd_hook.lua's ytdl binary file path and the ytdl json output available to other scripts #14097

Open
nurupo opened this issue May 9, 2024 · 3 comments · May be fixed by #14098
Open

Comments

@nurupo
Copy link

nurupo commented May 9, 2024

Expected behavior of the wanted feature

  1. Lua scripts are able to get the path to the ytdl binary that player/lua/ytdl_hook.lua has found.

  2. Lua scripts are able to get the ytdl json output that player/lua/ytdl_hook.lua has received from ytdl.

Why I want these features

I use yt-dlp in some of my scripts, and I want the scripts to use the same binary that ytdl_hook.lua uses, without the user having to specify the path to the ytdl binary in every scripts' options or the scripts duplicating the binary finding functionality of ytdl_hook.lua . It would be nice if ytdl_hook.lua made the ytdl binary path it has found available to all the scripts.

My scripts also need the yt-dlp --json-dump ... output that the ytdl_hook.lua script already receives, for example to determine if the video is a live-stream or a vod ( json["is_live"] ) and change things based on that, or to get the filename the video would have downloaded as ( json["filename"] ) , and if already exists on the disk - just open it from the disk, etc. It's very inefficient to have multiple scripts call ytdl --json-dump ... for the same URL to get the same json. It would be nice if ytdl_hook.lua made the output of --json-dump available to all the scripts.

@kasper93
Copy link
Contributor

See #12852

@christoph-heinrich
Copy link
Contributor

christoph-heinrich commented May 9, 2024

related #10410

@nurupo
Copy link
Author

Thanks for the pointers, got it working using user-data/ytdl/ properties.

It sounds like such a PR might get accepted, so I opened one.

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본