•  


Implement Torr Pressure-Converter Option by JacobPoteet · Pull Request #2121 · microsoft/calculator · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Torr Pressure-Converter Option #2121

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JacobPoteet
Copy link

Fixes #2120 .

Description of the changes:

  • Implements Torr as a pressure-conversion option
  • Torr can be converted to other data types

How changes were validated:

  • Added Unit Testing

…tainability

The code changes in this commit simplify the logic in the `OnAcceleratorKeyActivated` method of `KeyboardShortcutManager.cs`.

- Replaced nested if-else statements with concise conditional expressions
- Removed redundant checks for `altPressed` and `controlKeyPressed`
- Consolidated return statements based on key combinations
…s.h.

This commit adds the Pressure_Torr constant to the list of unit constants in the UnitConverterDataConstants.h file.
This commit adds the Torr unit to the list of pressure units in the UnitConverterDataLoader.cpp file. The Torr unit is assigned a value of 7 and its localized name and abbreviation are retrieved using GetLocalizedStringName(). Additionally, the conversion data for Torr is added to the GetConversionData() function.
The code changes include adding the unit abbreviation "Torr" for pressure measurement in the Resources.resw file. This change allows users to use "Torr" as an abbreviation when working with pressure calculations.
- Add new data entry for UnitName_Torr
- Set value to "Torr"
- Set comment to "A measurement unit for Pressure."
This commit adds a new conversion data entry for "Atmospheres-Torr" in the Test.resw file. The value of this conversion is 0.00131578947368.
The commit fixes a bug in the code where the pressure units were not being added correctly. The issue was resolved by moving the `emplace` statement after adding the `pressureUnits` vector.
@JacobPoteet
Copy link
Author

@microsoft-github-policy-service agree

@JacobPoteet
Copy link
Author

@tian-lt - Apologies for the ping but would it be possible to merge this small MR?

I'm not sure if there is someone else I should request reviews from.

@tian-lt
Copy link
Contributor

Thank you for proposing this PR, @JacobPoteet .
Let me first run the pipeline to check if it passes all the checks.

Adding @hanzhang54 @guominrui here to see if they have time to help review.

@tian-lt
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Torr to Pressure Unit Conversion
2 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본