Fixed incorrect `SignatureFlags.HasRestParameter` propagation when combining signatures #58440

Andarist · 2024-05-05T15:41:37Z

fixes #58371

…mbining signatures

Andarist · 2024-05-05T15:41:51Z

@jakebailey could you prepare a TS playground for this?

jakebailey · 2024-05-05T16:55:17Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-05-05T16:55:20Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	? Started	?? Results
`user test this`	? Started	? Results
`run dt`	? Started	? Results
`perf test this faster`	? Started	?? Results
`pack this`	? Started	? Results

typescript-bot · 2024-05-05T17:00:15Z

Hey @jakebailey , I've packed this into an installable tgz . You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161612/artifacts?artifactName=tgz&fileId=3D546827352718F58A299BE07ACE17C344B20098DF792AF548BE062279AED86502&fileName=/typescript-5.5.0-insiders.20240505.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58440-3".;

typescript-bot · 2024-05-05T17:16:05Z

Hey @jakebailey , the results of running the DT tests are ready.

Everything looks the same!

You can check the log here .

typescript-bot · 2024-05-05T17:18:38Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58440/merge:

Everything looks good!

typescript-bot · 2024-05-05T17:36:24Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,410k (± 0.96%)}	_{192,279k (± 0.09%)}	_~	_192,168k	_192,643k	_{p=0.471 n=6}
_{Parse Time}	_{1.30s (± 0.40%)}	_{1.30s (± 1.06%)}	_~	_1.28s	_1.32s	_{p=0.437 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.39%)}	_{9.53s (± 0.43%)}	_~	_9.48s	_9.60s	_{p=0.260 n=6}
_{Emit Time}	_{2.63s (± 0.47%)}	_{2.64s (± 0.52%)}	_~	_2.62s	_2.66s	_{p=0.183 n=6}
_{Total Time}	_{14.20s (± 0.24%)}	_{14.19s (± 0.32%)}	_~	_14.14s	_14.27s	_{p=0.624 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,322	_945,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_408,110	_408,110	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,836k (± 0.01%)}	_{1,222,781k (± 0.00%)}	_~	_1,222,728k	_1,222,839k	_{p=0.173 n=6}
_{Parse Time}	_{6.80s (± 0.83%)}	_{6.77s (± 0.60%)}	_~	_6.74s	_6.85s	_{p=0.334 n=6}
_{Bind Time}	_{1.88s (± 0.56%)}	_{1.88s (± 0.43%)}	_~	_1.86s	_1.88s	_{p=0.720 n=6}
_{Check Time}	_{31.39s (± 0.62%)}	_{31.33s (± 0.41%)}	_~	_31.16s	_31.47s	_{p=0.378 n=6}
_{Emit Time}	_{14.70s (± 0.57%)}	_{14.69s (± 0.52%)}	_~	_14.60s	_14.79s	_{p=0.630 n=6}
_{Total Time}	_{54.77s (± 0.49%)}	_{54.66s (± 0.30%)}	_~	_54.38s	_54.83s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,957,119	_1,957,151	_{+32 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_676,621	_676,617	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,765,535k (± 0.00%)}	_{1,765,540k (± 0.00%)}	_~	_1,765,485k	_1,765,585k	_{p=0.748 n=6}
_{Parse Time}	_{6.70s (± 0.24%)}	_{6.70s (± 0.36%)}	_~	_6.68s	_6.74s	_{p=0.803 n=6}
_{Bind Time}	_{2.32s (± 0.59%)}	_{2.30s (± 0.45%)}	_~	_2.29s	_2.32s	_{p=0.095 n=6}
_{Check Time}	_{56.35s (± 0.37%)}	_{56.24s (± 0.29%)}	_~	_55.99s	_56.42s	_{p=0.336 n=6}
_{Emit Time}	_{0.14s (± 2.88%)}	_0.14s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{65.51s (± 0.32%)}	_{65.38s (± 0.25%)}	_~	_65.12s	_65.55s	_{p=0.297 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,388	_1,217,393	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,008	_259,008	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,327,862k (± 0.03%)}	_{2,327,811k (± 0.03%)}	_~	_2,327,025k	_2,328,905k	_{p=0.810 n=6}
_{Parse Time}	_{4.94s (± 0.78%)}	_{4.94s (± 1.08%)}	_~	_4.89s	_5.03s	_{p=0.810 n=6}
_{Bind Time}	_{1.87s (± 1.17%)}	_{1.87s (± 1.14%)}	_~	_1.85s	_1.91s	_{p=1.000 n=6}
_{Check Time}	_{33.49s (± 0.43%)}	_{33.57s (± 0.36%)}	_~	_33.34s	_33.66s	_{p=0.298 n=6}
_{Emit Time}	_{2.60s (± 2.75%)}	_{2.60s (± 0.82%)}	_~	_2.57s	_2.63s	_{p=0.936 n=6}
_{Total Time}	_{42.92s (± 0.47%)}	_{43.01s (± 0.32%)}	_~	_42.77s	_43.13s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,388	_1,217,393	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,008	_259,008	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,402,844k (± 0.01%)}	_{2,402,847k (± 0.01%)}	_~	_2,402,495k	_2,403,252k	_{p=1.000 n=6}
_{Parse Time}	_{6.17s (± 0.63%)}	_{6.18s (± 0.82%)}	_~	_6.13s	_6.24s	_{p=1.000 n=6}
_{Bind Time}	_{2.06s (± 0.99%)}	_{2.01s (± 1.25%)}	_{-0.05s (- 2.51%)}	_1.97s	_2.03s	_{p=0.006 n=6}
_{Check Time}	_{40.09s (± 0.33%)}	_{40.12s (± 0.24%)}	_~	_39.97s	_40.26s	_{p=0.630 n=6}
_{Emit Time}	_{3.14s (± 1.27%)}	_{3.13s (± 1.05%)}	_~	_3.08s	_3.17s	_{p=0.748 n=6}
_{Total Time}	_{51.46s (± 0.32%)}	_{51.45s (± 0.22%)}	_~	_51.24s	_51.55s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,310	_256,315	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,458	_104,458	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,923k (± 0.00%)}	_{424,922k (± 0.01%)}	_~	_424,897k	_424,973k	_{p=0.630 n=6}
_{Parse Time}	_{3.37s (± 0.64%)}	_{3.35s (± 0.84%)}	_~	_3.31s	_3.38s	_{p=0.332 n=6}
_{Bind Time}	_{1.29s (± 1.14%)}	_{1.30s (± 1.15%)}	_~	_1.28s	_1.32s	_{p=0.190 n=6}
_{Check Time}	_{17.71s (± 0.19%)}	_{17.77s (± 0.46%)}	_~	_17.69s	_17.91s	_{p=0.261 n=6}
_{Emit Time}	_{1.34s (± 0.87%)}	_{1.34s (± 0.73%)}	_~	_1.33s	_1.35s	_{p=0.673 n=6}
_{Total Time}	_{23.71s (± 0.20%)}	_{23.76s (± 0.33%)}	_~	_23.67s	_23.89s	_{p=0.288 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,826	_224,826	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,115	_94,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,950k (± 0.03%)}	_{369,896k (± 0.04%)}	_~	_369,802k	_370,144k	_{p=0.173 n=6}
_{Parse Time}	_{3.50s (± 0.86%)}	_{3.52s (± 0.85%)}	_~	_3.49s	_3.56s	_{p=0.373 n=6}
_{Bind Time}	_{1.94s (± 0.27%)}	_{1.95s (± 0.79%)}	_~	_1.93s	_1.97s	_{p=0.548 n=6}
_{Check Time}	_{19.34s (± 0.40%)}	_{19.30s (± 0.30%)}	_~	_19.24s	_19.40s	_{p=0.374 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.78s (± 0.29%)}	_{24.77s (± 0.27%)}	_~	_24.72s	_24.90s	_{p=0.517 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,804,834	_2,804,799	_{-35 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_952,325	_952,323	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,976,987k (± 0.00%)}	_{2,976,915k (± 0.00%)}	_~	_2,976,754k	_2,977,062k	_{p=0.471 n=6}
_{Parse Time}	_{16.87s (± 0.30%)}	_{16.93s (± 1.13%)}	_~	_16.80s	_17.31s	_{p=1.000 n=6}
_{Bind Time}	_{4.96s (± 0.35%)}	_{4.98s (± 1.66%)}	_~	_4.92s	_5.14s	_{p=0.677 n=6}
_{Check Time}	_{88.50s (± 2.10%)}	_{88.07s (± 0.29%)}	_~	_87.80s	_88.49s	_{p=0.298 n=6}
_{Emit Time}	_{27.90s (± 6.80%)}	_{28.84s (± 1.12%)}	_~	_28.48s	_29.18s	_{p=0.230 n=6}
_{Total Time}	_{138.23s (± 0.21%)}	_{138.82s (± 0.30%)}	_{+0.59s (+ 0.43%)}	_138.42s	_139.37s	_{p=0.031 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,864	_265,864	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,449	_108,449	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,535k (± 0.02%)}	_{410,468k (± 0.02%)}	_~	_410,373k	_410,604k	_{p=0.336 n=6}
_{Parse Time}	_{4.76s (± 1.25%)}	_{4.75s (± 0.81%)}	_~	_4.70s	_4.79s	_{p=0.571 n=6}
_{Bind Time}	_{2.07s (± 0.43%)}	_{2.07s (± 0.47%)}	_~	_2.06s	_2.08s	_{p=0.798 n=6}
_{Check Time}	_{21.00s (± 0.32%)}	_{21.00s (± 0.43%)}	_~	_20.85s	_21.11s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.84s (± 0.15%)}	_{27.81s (± 0.39%)}	_~	_27.65s	_27.97s	_{p=0.808 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,961	_524,961	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,070	_179,070	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,856k (± 0.02%)}	_{462,853k (± 0.01%)}	_~	_462,760k	_462,944k	_{p=0.936 n=6}
_{Parse Time}	_{3.88s (± 0.51%)}	_{3.87s (± 0.22%)}	_~	_3.85s	_3.87s	_{p=0.123 n=6}
_{Bind Time}	_{1.43s (± 1.28%)}	_{1.44s (± 1.16%)}	_~	_1.42s	_1.47s	_{p=0.357 n=6}
_{Check Time}	_{22.49s (± 0.37%)}	_{22.42s (± 0.64%)}	_~	_22.27s	_22.62s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.81s (± 0.31%)}	_{27.73s (± 0.52%)}	_~	_27.57s	_27.92s	_{p=0.230 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-05T18:46:19Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58440/merge:

Something interesting changed - please have a look.

Details

honojs/hono

4 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2345: Argument of type 'any[] | undefined' is not assignable to parameter of type 'string'.
- src/helper/dev/index.test.ts#L65
- src/helper/dev/index.test.ts#L136

ueberdosis/tiptap

3 of 8 projects failed to build with the old tsc and were ignored

tests/cypress/tsconfig.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.vue-3.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.vue-2.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.react.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.base.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

Andarist · 2024-05-06T08:19:09Z

hono change: TS playground (definitely not OK)

RyanCavanaugh · 2024-05-06T21:20:46Z

Are you saying hono definitely isn't OK, or the behavior introduced by this PR is definitely not OK?

Andarist · 2024-05-06T22:22:57Z

Oops, I can see how my comment was confusing ??

I meant that the behavior change with my PR was definitely not OK in the hono's case. On the other hand, I think that the behavior change in tiptap was OK - that should report the error. We can compare those 2 playground:

We can see here, on the second one, that the error is reported. On the first one, we pass the same argument - but the function(s) with this parameters were processed by RemoveThis. The resulting functions are conceptually the same as the ones on the second playground.

On top of that, we can remove Extension* types from AnyConfig and AnyExtension to make them unions of 2 types each instead of unions of 3 types each to see the error being reported: TS playground . It's worth noting here that the reported error is not completely OK either as it mentions "Argument of type '[Mark]'" but it should mention "Argument of type 'Mark'".

I pushed out a fix for hono and tests based on tiptap. Could we run extended tests on this and build a new playground?

jakebailey · 2024-05-06T22:23:55Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-05-06T22:23:58Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	? Started	?? Results
`user test this`	? Started	? Results
`run dt`	? Started	? Results
`perf test this faster`	? Started	?? Results
`pack this`	? Started	? Results

Andarist · 2024-05-06T22:24:07Z

src/compiler/checker.ts

@@ -31261,12 +31266,13 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
            const paramSymbol = createSymbol(
                SymbolFlags.FunctionScopedVariable | (isOptional && !isRestParam ? SymbolFlags.Optional : 0),
                paramName || `arg${i}` as __String,
+                isRestParam ? CheckFlags.RestParameter : isOptional ? CheckFlags.OptionalParameter : 0,


adding CheckFlags.RestParameter here is based on the similar change from #55625

typescript-bot · 2024-05-06T22:29:09Z

Hey @jakebailey , I've packed this into an installable tgz . You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161632/artifacts?artifactName=tgz&fileId=DA54CA37B9AA73C8097AC2134D6947B577A94B50517AC1BAE0F007CB13CF8F5002&fileName=/typescript-5.5.0-insiders.20240506.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58440-13".;

typescript-bot · 2024-05-06T22:47:01Z

Hey @jakebailey , the results of running the DT tests are ready.

Everything looks the same!

You can check the log here .

typescript-bot · 2024-05-06T23:02:42Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58440/merge:

Everything looks good!

typescript-bot · 2024-05-06T23:05:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,348k (± 0.11%)}	_{194,064k (± 1.00%)}	_~	_192,152k	_195,856k	_{p=0.471 n=6}
_{Parse Time}	_{1.30s (± 1.09%)}	_{1.30s (± 0.80%)}	_~	_1.28s	_1.31s	_{p=0.738 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.54s (± 0.29%)}	_{9.55s (± 0.56%)}	_~	_9.48s	_9.63s	_{p=1.000 n=6}
_{Emit Time}	_{2.64s (± 0.24%)}	_{2.64s (± 0.44%)}	_~	_2.62s	_2.65s	_{p=1.000 n=6}
_{Total Time}	_{14.20s (± 0.28%)}	_{14.20s (± 0.35%)}	_~	_14.14s	_14.27s	_{p=0.627 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,322	_945,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_408,110	_408,110	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,819k (± 0.00%)}	_{1,222,813k (± 0.01%)}	_~	_1,222,691k	_1,222,962k	_{p=0.689 n=6}
_{Parse Time}	_{6.81s (± 0.46%)}	_{6.77s (± 0.56%)}	_~	_6.72s	_6.81s	_{p=0.106 n=6}
_{Bind Time}	_{1.88s (± 0.40%)}	_{1.88s (± 0.56%)}	_~	_1.86s	_1.89s	_{p=0.611 n=6}
_{Check Time}	_{31.31s (± 0.62%)}	_{31.31s (± 0.35%)}	_~	_31.23s	_31.53s	_{p=0.936 n=6}
_{Emit Time}	_{14.75s (± 0.51%)}	_{14.70s (± 0.71%)}	_~	_14.57s	_14.85s	_{p=0.423 n=6}
_{Total Time}	_{54.75s (± 0.44%)}	_{54.66s (± 0.37%)}	_~	_54.43s	_55.03s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,957,194	_1,957,194	_~	_~	_~	_{p=1.000 n=6}
_Types	_676,642	_676,642	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,765,682k (± 0.00%)}	_{1,765,673k (± 0.00%)}	_~	_1,765,645k	_1,765,711k	_{p=0.575 n=6}
_{Parse Time}	_{6.70s (± 0.12%)}	_{6.70s (± 0.25%)}	_~	_6.68s	_6.73s	_{p=0.866 n=6}
_{Bind Time}	_{2.32s (± 0.22%)}	_{2.32s (± 0.39%)}	_~	_2.31s	_2.33s	_{p=0.541 n=6}
_{Check Time}	_{56.48s (± 0.24%)}	_{56.37s (± 0.43%)}	_~	_55.97s	_56.70s	_{p=0.336 n=6}
_{Emit Time}	_{0.14s (± 5.69%)}	_0.14s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{65.64s (± 0.21%)}	_{65.53s (± 0.36%)}	_~	_65.13s	_65.86s	_{p=0.423 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,450	_1,217,455	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,040	_259,040	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,328,391k (± 0.03%)}	_{2,327,944k (± 0.01%)}	_~	_2,327,607k	_2,328,348k	_{p=0.378 n=6}
_{Parse Time}	_{5.00s (± 1.13%)}	_{5.01s (± 1.10%)}	_~	_4.95s	_5.11s	_{p=0.520 n=6}
_{Bind Time}	_{1.87s (± 0.63%)}	_{1.87s (± 1.00%)}	_~	_1.85s	_1.89s	_{p=0.806 n=6}
_{Check Time}	_{33.42s (± 0.52%)}	_{33.33s (± 0.28%)}	_~	_33.20s	_33.43s	_{p=0.378 n=6}
_{Emit Time}	_{2.59s (± 1.14%)}	_{2.65s (± 1.28%)}	_{+0.06s (+ 2.32%)}	_2.59s	_2.69s	_{p=0.013 n=6}
_{Total Time}	_{42.90s (± 0.56%)}	_{42.85s (± 0.21%)}	_~	_42.69s	_42.95s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,450	_1,217,455	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,040	_259,040	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,404,087k (± 0.03%)}	_{2,403,974k (± 0.04%)}	_~	_2,402,494k	_2,404,836k	_{p=0.936 n=6}
_{Parse Time}	_{7.71s (± 0.76%)}	_{7.73s (± 1.83%)}	_~	_7.60s	_7.99s	_{p=0.810 n=6}
_{Bind Time}	_{2.46s (± 0.92%)}	_{2.48s (± 1.39%)}	_~	_2.43s	_2.53s	_{p=0.294 n=6}
_{Check Time}	_{49.40s (± 0.26%)}	_{49.52s (± 0.66%)}	_~	_49.26s	_50.17s	_{p=0.689 n=6}
_{Emit Time}	_{3.79s (± 1.65%)}	_{3.80s (± 2.36%)}	_~	_3.69s	_3.93s	_{p=1.000 n=6}
_{Total Time}	_{63.37s (± 0.11%)}	_{63.55s (± 0.79%)}	_~	_63.18s	_64.53s	_{p=0.873 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,369	_256,374	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,483	_104,483	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,987k (± 0.01%)}	_{425,019k (± 0.01%)}	_~	_424,964k	_425,066k	_{p=0.230 n=6}
_{Parse Time}	_{3.37s (± 0.36%)}	_{3.37s (± 0.35%)}	_~	_3.35s	_3.38s	_{p=0.673 n=6}
_{Bind Time}	_{1.30s (± 1.32%)}	_{1.30s (± 0.79%)}	_~	_1.29s	_1.32s	_{p=0.803 n=6}
_{Check Time}	_{17.80s (± 0.33%)}	_{17.77s (± 0.38%)}	_~	_17.72s	_17.90s	_{p=0.334 n=6}
_{Emit Time}	_{1.38s (± 2.19%)}	_{1.37s (± 1.93%)}	_~	_1.33s	_1.40s	_{p=1.000 n=6}
_{Total Time}	_{23.84s (± 0.42%)}	_{23.82s (± 0.22%)}	_~	_23.78s	_23.92s	_{p=0.571 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,826	_224,826	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,115	_94,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,921k (± 0.03%)}	_{369,985k (± 0.05%)}	_~	_369,855k	_370,326k	_{p=0.521 n=6}
_{Parse Time}	_{2.83s (± 0.89%)}	_{2.81s (± 0.89%)}	_~	_2.78s	_2.84s	_{p=0.224 n=6}
_{Bind Time}	_{1.58s (± 0.52%)}	_{1.59s (± 0.84%)}	_~	_1.57s	_1.61s	_{p=0.112 n=6}
_{Check Time}	_{15.58s (± 0.36%)}	_{15.57s (± 0.47%)}	_~	_15.47s	_15.68s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.98s (± 0.32%)}	_{19.97s (± 0.37%)}	_~	_19.86s	_20.07s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,807,082	_2,807,082	_~	_~	_~	_{p=1.000 n=6}
_Types	_952,919	_952,919	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,978,811k (± 0.00%)}	_{2,978,895k (± 0.00%)}	_~	_2,978,733k	_2,979,041k	_{p=0.298 n=6}
_{Parse Time}	_{16.96s (± 0.26%)}	_{16.96s (± 0.47%)}	_~	_16.86s	_17.07s	_{p=1.000 n=6}
_{Bind Time}	_{5.00s (± 0.50%)}	_{4.98s (± 0.32%)}	_~	_4.97s	_5.01s	_{p=0.402 n=6}
_{Check Time}	_{88.22s (± 0.38%)}	_{88.56s (± 0.31%)}	_~	_88.12s	_88.91s	_{p=0.093 n=6}
_{Emit Time}	_{28.70s (± 0.52%)}	_{28.81s (± 0.70%)}	_~	_28.53s	_29.05s	_{p=0.376 n=6}
_{Total Time}	_{138.87s (± 0.34%)}	_{139.31s (± 0.34%)}	_~	_138.60s	_139.89s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,864	_265,864	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,449	_108,449	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,477k (± 0.02%)}	_{410,489k (± 0.02%)}	_~	_410,417k	_410,577k	_{p=0.689 n=6}
_{Parse Time}	_{4.76s (± 0.87%)}	_{4.74s (± 0.84%)}	_~	_4.69s	_4.79s	_{p=0.334 n=6}
_{Bind Time}	_{2.07s (± 1.08%)}	_{2.06s (± 0.94%)}	_~	_2.03s	_2.09s	_{p=0.456 n=6}
_{Check Time}	_{21.00s (± 0.34%)}	_{21.00s (± 0.25%)}	_~	_20.95s	_21.09s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.83s (± 0.19%)}	_{27.80s (± 0.33%)}	_~	_27.71s	_27.92s	_{p=0.575 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,961	_524,961	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,070	_179,070	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,878k (± 0.02%)}	_{462,881k (± 0.02%)}	_~	_462,748k	_463,018k	_{p=1.000 n=6}
_{Parse Time}	_{3.87s (± 0.66%)}	_{3.88s (± 0.66%)}	_~	_3.85s	_3.91s	_{p=0.624 n=6}
_{Bind Time}	_{1.43s (± 0.95%)}	_{1.44s (± 1.20%)}	_~	_1.42s	_1.46s	_{p=0.676 n=6}
_{Check Time}	_{22.48s (± 0.55%)}	_{22.37s (± 0.58%)}	_~	_22.22s	_22.54s	_{p=0.149 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.79s (± 0.42%)}	_{27.69s (± 0.48%)}	_~	_27.55s	_27.87s	_{p=0.335 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-07T00:05:47Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58440/merge:

Something interesting changed - please have a look.

Details

ueberdosis/tiptap

3 of 8 projects failed to build with the old tsc and were ignored

tests/cypress/tsconfig.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.vue-3.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.vue-2.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.react.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

demos/tsconfig.base.json

error TS2345: Argument of type 'Mark<any, any>' is not assignable to parameter of type 'Mark<any, any> & Node<any, any>'.
- packages/core/src/helpers/getSchemaByResolvedExtensions.ts#L141

Fixed incorrect SignatureFlags.HasRestParameter propagation when co…

7654eaa

…mbining signatures

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 5, 2024

Andarist mentioned this pull request May 5, 2024

tsc crash with "TypeError: Cannot read properties of undefined (reading 'flags')" #58371

Open

set correctly checkFlags when combining intersection parameters

c208533

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 6, 2024

Andarist commented May 6, 2024

View reviewed changes

simplify added tests

777b156

Fixed incorrect SignatureFlags.HasRestParameter propagation when combining signatures #58440

Are you sure you want to change the base?

Fixed incorrect SignatureFlags.HasRestParameter propagation when combining signatures #58440

Conversation

Andarist commented May 5, 2024

Andarist commented May 5, 2024

jakebailey commented May 5, 2024

typescript-bot commented May 5, 2024 • edited

typescript-bot commented May 5, 2024 • edited

typescript-bot commented May 5, 2024

typescript-bot commented May 5, 2024

typescript-bot commented May 5, 2024

tsc

typescript-bot commented May 5, 2024

Andarist commented May 6, 2024 • edited

RyanCavanaugh commented May 6, 2024

Andarist commented May 6, 2024

jakebailey commented May 6, 2024

typescript-bot commented May 6, 2024 • edited

Choose a reason for hiding this comment

typescript-bot commented May 6, 2024 • edited

typescript-bot commented May 6, 2024

typescript-bot commented May 6, 2024

typescript-bot commented May 6, 2024

tsc

typescript-bot commented May 7, 2024

Fixed incorrect `SignatureFlags.HasRestParameter` propagation when combining signatures #58440

Fixed incorrect `SignatureFlags.HasRestParameter` propagation when combining signatures #58440

typescript-bot commented May 5, 2024 •

edited

typescript-bot commented May 5, 2024 •

edited

Andarist commented May 6, 2024 •

edited

typescript-bot commented May 6, 2024 •

edited

typescript-bot commented May 6, 2024 •

edited