•  


Compute flow types for function declarations by Andarist · Pull Request #58411 · microsoft/TypeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute flow types for function declarations #58411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compute flow types for function declarations #58411

wants to merge 1 commit into from

Conversation

Andarist
Copy link
Contributor

fixes #41232

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 2, 2024
Andarist
Andarist commented May 2, 2024
View reviewed changes
src/compiler/checker.ts
Comment on lines +29396 to 29397
// We only narrow variables, parameters and functions occurring in a non-assignment position. For all other
// entities we simply return the declared type.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

tbf... if this is something the plan would like to pull in, we probably should enable narrowing on just anything. asserts make it possible to expand all non-nullable types

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asserts keyword does not enhance hoisted function type, works on functions assigned to a variable
2 participants
@Andarist @typescript-bot
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close