•  


[Bug] Limit on /search is not deterministic · Issue #73 · mendableai/firecrawl · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Limit on /search is not deterministic #73

Closed
nickscamara opened this issue Apr 25, 2024 · 0 comments
Closed

[Bug] Limit on /search is not deterministic #73

nickscamara opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nickscamara
Copy link
Member

nickscamara commented Apr 25, 2024

Right now we limit the search results by applying it to the serp api level by using searchOptions.limit : n .

The problem is that some search results could be social media pages or website that we don't support, failing it on it. This ends up causing the /search endpoint to return less results than expected.

The idea here is that we should search for n + y over the limit, where n is the limit and y is a picked constant. That way if it fails, we can use the y links and try to call get documents on it until we hit the correct limit n.

@nickscamara nickscamara added the bug Something isn't working label Apr 25, 2024
@nickscamara nickscamara added the good first issue Good for newcomers label May 6, 2024
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본