•  


[Feat] Be able to pass a timeout param to the endpoints · Issue #59 · mendableai/firecrawl · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Be able to pass a timeout param to the endpoints #59

Open
nickscamara opened this issue Apr 24, 2024 · 6 comments
Open

[Feat] Be able to pass a timeout param to the endpoints #59

nickscamara opened this issue Apr 24, 2024 · 6 comments
Assignees

Comments

@nickscamara
Copy link
Member

nickscamara commented Apr 24, 2024

enable the user to pass a "timeout parameter" to both the scrape and the crawl endpoint. If the timeout is exceeded, please send the user a clear error message. On the crawl endpoint, return any pages that have already been scraped but include messages notifying them that the timeout was exceeded.

If the task is completed within two days, we'll include a $10 dollar tip :)

This is an intro bounty. We are looking for exciting people that will buy in so we can start to ramp up.

Copy link

algora-pbc bot commented Apr 25, 2024

?? $15 bounty ? Mendable (YC S22)

Steps to solve:

  1. Start working : Comment /attempt #59 with your implementation plan
  2. Submit work : Create a pull request including /claim #59 in the PR body to claim the bounty
  3. Receive payment : 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to mendableai/firecrawl!

Add a bounty ? Share on socials

DO NOT START WORKING ON THIS BEFORE GETTING ASSIGNED, OTHERWISE WE CAN'T AWARD THE BOUNTY
Other attempts will be allowed if the user assigned does not open a PR within 48 hours.

@ezhil56x
Copy link

ezhil56x commented Apr 25, 2024

@nickscamara
Can I get assigned?

@nickscamara
Copy link
Member Author

@ezhil56x all yours!

@nickscamara nickscamara changed the title [Feat]: Be able to pass a timeout param to /scrape endpoints [Feat]: Be able to pass a timeout param to the endpoints Apr 25, 2024
@ezhil56x
Copy link

@nickscamara
Do we need a default timeout or not required?

@kesh-007 kesh-007 mentioned this issue Apr 25, 2024
@rafaelsideguide rafaelsideguide changed the title [Feat]: Be able to pass a timeout param to the endpoints [Feat] Be able to pass a timeout param to the endpoints May 2, 2024
@parthusun8
Copy link

parthusun8 commented Jun 8, 2024

Hi, Is this issue still open, or is someone working on it?

@rafaelsideguide
Copy link
Collaborator

@parthusun8 , the issue is still open, but fixing it would need us to make some real complex changes to our bull queue system to allow the /crawl route to timeout. So far, we’ve found that stopping an active job in bull isn’t possible. This means we’d have to change the deepest parts of our system to add a timeout feature to Firecrawl.

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본