•  


feat(refresher): add ionEnd event by WhatsThatItsPat · Pull Request #24526 · ionic-team/ionic-framework · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refresher): add ionEnd event #24526

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WhatsThatItsPat
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build ( npm run build ) was run locally and any changes were pushed
  • Lint ( npm run lint ) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number:
#24524

What is the new behavior?

This adds an ionEnd event as an obverse to the ionStart event.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR appears to work for the web, but I'm not sure if more has to be done for the native refreshers. There are a couple of comments that can be cleaned up after clarification on this.

@WhatsThatItsPat WhatsThatItsPat requested a review from a team as a code owner January 6, 2022 20:37
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Jan 6, 2022
@liamdebeasi liamdebeasi removed the request for review from a team May 22, 2023 15:01
@WhatsThatItsPat WhatsThatItsPat requested a review from a team as a code owner January 24, 2024 17:55
@WhatsThatItsPat WhatsThatItsPat requested review from amandaejohnston and removed request for a team January 24, 2024 17:55
@brandyscarney brandyscarney removed the request for review from amandaejohnston May 10, 2024 20:42
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본