•  


fix: Update flow.py by octaflop · Pull Request #349 · googleapis/google-auth-library-python-oauthlib · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update flow.py #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octaflop
Copy link

This commit fixes a case in which a user has deleted the token.json and attempts to reauthorize. The user will find the reauthorization to work, but without the prompt=consent query parameter being sent to google's oauth, no new refresh_token will be sent.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #348 ??

Feel free to make any other changes / updates.

personal workaround:

url_args
 =
 {
    
'access_type'
: 
'offline'
,
    
'prompt'
: 
'consent'

}
flow
 =
 InstalledAppFlow
.
from_client_secrets_file
(
    
str
(
credentials_path
), 
SCOPES
)
try
:
    
creds
 =
 flow
.
run_local_server
(
port
=
8080
, 
open_browser
=
False
, 
**
url_args
)

except
 MismatchingStateError
:
    
print
(
"State mismatch error during OAuth process. Trying again..."
)
    
creds
 =
 flow
.
run_local_server
(
port
=
8080
, 
open_browser
=
False
, 
**
url_args
)

This commit fixes a case in which a user has deleted the token.json and attempts to reauthorize. The user will find the reauthorization to work, but without the `prompt=consent` query parameter being sent to google's oauth, no new refresh_token will be sent.
@octaflop octaflop requested review from a team as code owners May 6, 2024 20:48
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 6, 2024
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh_token not regenerated with current authorization_url defaults.
2 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본