We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation .
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo version
hugo v0.125.4+extended darwin/arm64 BuildDate=2024-04-25T13:27:26Z VendorInfo=brew
Yes.
After upgrading to v0.125 I see changes like the following for categories/index.xml and tags/index.xml files:
categories/index.xml
tags/index.xml
- <pubDate>Sat, 27 Oct 2018 08:30:00 +0000</pubDate> + <pubDate>Mon, 01 Jan 0001 00:00:00 +0000</pubDate>
For subindex files like categories/foo/index.xml the pubDate is set to the expected value, i.e. the generated output is identical to versions < v0.125.
categories/foo/index.xml
pubDate
From looking at the changelog and commit f0a26cf58e9bfbe55c091d51a4133bc22cad5d1f it's not clear to me what needs to be changed in order to retain the previous (default) selection of values for pubDate ? Am I missing something?
Also, with above hugo version {{ hugo.Version }} doesn't seem to be set, resulting in the following output for the generator tag:
{{ hugo.Version }}
generator
- <generator>Hugo -- gohugo.io</generator> + <generator>Hugo</generator>
The text was updated successfully, but these errors were encountered:
@schu
The version string was added to the generator tag in v0.125.0 to address #11692 , and was removed in v0.125.3 to address #12300 (comment) . We should have closed #11692 as "won't fix".
I'll look into the zero pubdate problem.
Sorry, something went wrong.
The Date and Lastmod roll-up to section, taxonomy, and term pages. The PublishDate does not "roll-up".
Date
Lastmod
PublishDate
I think the PublishDate should roll-up to the latest date before now(). If we rolled-up dates after now(), that would cause the section, taxonomy, or term page to not be published even if there's other descendant content.
Applicable to:
This isn't something new (i.e., same behavior in v0.122.0).
The test case below does not test for what should happen with publish dates greater than now() as described above.
func TestFoo ( t * testing. T ) { t . Parallel () files := ` -- hugo.toml -- disableKinds = ['home','rss','sitemap'] [taxonomies] tag = 'tags' -- layouts/_default/list.html -- Date: {{ .Date.Format "2006-01-02" }} PublishDate: {{ .PublishDate.Format "2006-01-02" }} Lastmod: {{ .Lastmod.Format "2006-01-02" }} -- layouts/_default/single.html -- {{ .Title }} -- content/s1/p1.md -- --- title: p1 date: 2024-03-01 lastmod: 2024-03-02 tags: [t1] --- -- content/s1/p2.md -- --- title: p2 date: 2024-04-03 lastmod: 2024-04-04 tags: [t1] --- ` // Test without publishDate in front matter. b := hugolib . Test ( t , files ) b . AssertFileContent ( "public/s1/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-04 ` ) b . AssertFileContent ( "public/tags/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-04 ` ) b . AssertFileContent ( "public/tags/t1/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-04 ` ) // Test with publishDate in front matter. files = strings . ReplaceAll ( files , "lastmod" , "publishDate" ) b = hugolib . Test ( t , files ) b . AssertFileContent ( "public/s1/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-03 ` ) b . AssertFileContent ( "public/tags/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-03 ` ) b . AssertFileContent ( "public/tags/t1/index.html" , ` Date: 2024-04-03 PublishDate: 2024-04-03 Lastmod: 2024-04-03 ` ) }
I think the PublishDate should roll-up to the latest date before now().
Yea, that sounds reasonable.
Is there a workaround that I could apply to get back the old behavior?
Or is there a chance to revert to the old behavior until a working fix is found?
Override the embedded RSS template, and change this line:
hugo/tpl/tplimpl/embedded/templates/_default/rss.xml
Line 64 in 3d40aba
To:
<pubDate>{{ (or .PublishDate .Date).Format "Mon, 02 Jan 2006 15:04:05 -0700" | safeHTML }}</pubDate>
If the page has a publication date, use that, else use the date.
Add workaround for Hugo PublishDate regression
5be1b92
Add a custom `rss.xml` default layout with a workaround for a `PublishDate` regression for Hugo v0.125 and newer where the `PublishDate` does not get set correctly for all generated files. Details can be found here: gohugoio/hugo#12438 Hugo documentation: https://gohugo.io/templates/rss/#template-lookup-order The `rss.xml` file is based on the upstream default template found here: ``` curl -LO https://raw.githubusercontent.com/gohugoio/hugo/3d40aba512931031921463dafc172c0d124437b8/tpl/tplimpl/embedded/templates/_default/rss.xml ``` The changed line is: ``` <pubDate>{{ (or .PublishDate .Date).Format "Mon, 02 Jan 2006 15:04:05 -0700" | safeHTML }}</pubDate> ```
Override the embedded RSS template [...]
Thanks, that worked.
For other readers: download the default rss.xml template to layouts/_default/rss.xml and change the pubDate line as shown above.
layouts/_default/rss.xml
No branches or pull requests
