•  


[CP-stable]Fix another instance of platform view breakage on Android 14 by flutteractionsbot · Pull Request #52982 · flutter/engine · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-stable]Fix another instance of platform view breakage on Android 14 #52982

Merged
merged 2 commits into from
May 31, 2024
Merged

[CP-stable]Fix another instance of platform view breakage on Android 14 #52982

merged 2 commits into from
May 31, 2024

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented May 22, 2024 •
edited by reidbaker

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link

Fixes flutter/flutter#148662
CP bug flutter/flutter#148885

Target

stable

PR Link

TBD

Changelog Description

Platform view fix for android 14 when multiple activities are used and onMemoryTrim is called.

Impacted Users

Users shipping flutter apps on android 14 that use platform viewss

Impact Description

Platform views stop rendering new frames.

Workaround

No app level work around.

Risk

low

Test Coverage

no

Validation Steps

App is launched
App is backgrounded (via a back-gesture swipe)
Android Bug triggers HERE
no onTrimMemory callback fires
App is resumed
Platform views don't render

@johnmccutchan
Fix another instance of platform view breakage on Android 14 ( flutter…
92d8f1f 
…#52980
)

When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs.

Workaround this by faking an onTrimMemory callback in the `Activity#onStop` callback.

Fixes #148662
Related #146499

Tested manually on a Pixel 7 Pro running Android 14.
@flutteractionsbot flutteractionsbot added the cp: review add the cp request to the review queue of release engineers label May 22, 2024
@flutteractionsbot
Copy link
Author

@reidbaker please fill out the PR description above, afterwards the release team will review this request.

@zanderso zanderso mentioned this pull request May 28, 2024
Closed
@reidbaker reidbaker mentioned this pull request May 30, 2024
Closed
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2024
@auto-submit auto-submit bot merged commit 1801d3b into flutter : flutter-3.22-candidate.0 May 31, 2024
23 checks passed
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

@reidbaker reidbaker reidbaker approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review add the cp request to the review queue of release engineers platform-android
Projects
None yet
Milestone
No milestone
4 participants
@flutteractionsbot @johnmccutchan @reidbaker @itsjustkevin
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close