•  


feat(messaging): change usage of `Platform.isIos` to `defaultTargetPlatform` to allow mocking platform more easily by fachrifaul · Pull Request #12183 · firebase/flutterfire · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(messaging): change usage of Platform.isIos to defaultTargetPlatform to allow mocking platform more easily #12183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(messaging): change usage of Platform.isIos to defaultTargetPlatform to allow mocking platform more easily #12183

wants to merge 4 commits into from

Conversation

fachrifaul
Copy link

@fachrifaul fachrifaul commented Jan 22, 2024 •
edited

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Hard to mock Platform, need to change to defaultTargetPlatform

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database . Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ( [x] ).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide ).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with /// ).
  • The analyzer ( melos run analyze ) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide .
  • I signed the CLA .
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla Google CLA
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fachrifaul fachrifaul changed the title For better mocking platform fix(messaging): mocking platform Jan 22, 2024
@Lyokone Lyokone changed the title fix(messaging): mocking platform feat(messaging): make mocking platform easier Jan 23, 2024
@Lyokone Lyokone changed the title feat(messaging): make mocking platform easier feat(messaging): makes mocking platform easier Jan 23, 2024
@Lyokone Lyokone changed the title feat(messaging): makes mocking platform easier feat(messaging): change usage of Platform.isIos to defaultTargetPlatform to allow to mock platform more easily Jan 23, 2024
@Lyokone Lyokone changed the title feat(messaging): change usage of Platform.isIos to defaultTargetPlatform to allow to mock platform more easily feat(messaging): change usage of Platform.isIos to defaultTargetPlatform to allow mocking platform more easily Jan 23, 2024
@Lyokone
Update packages/firebase_messaging/firebase_messaging_platform_interf…
64702c9 
…ace/lib/src/method_channel/method_channel_messaging.dart
russellwheatley
russellwheatley requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

@fachrifaul - You need to remove this import from the same file you changed: https://github.com/firebase/flutterfire/actions/runs/7626531820/job/20773125499?pr=12183#step:5:241

@fachrifaul
Copy link
Author

@fachrifaul - You need to remove this import from the same file you changed: https://github.com/firebase/flutterfire/actions/runs/7626531820/job/20773125499?pr=12183#step:5:241

Done

ellet0
ellet0 reviewed Jan 24, 2024
View reviewed changes
...g/firebase_messaging_platform_interface/lib/src/method_channel/method_channel_messaging.dart
Comment on lines +133 to +134
if (defaultTargetPlatform == TargetPlatform.iOS ||
defaultTargetPlatform == TargetPlatform.macOS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

defaultTargetPlatform doesn't care if the platform is running on web browser or not, it could be TargetPlatform.iOS but on web browser, we need to handle this case as well

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@Lyokone Lyokone Lyokone approved these changes

@ellet0 ellet0 ellet0 left review comments

@russellwheatley russellwheatley russellwheatley requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
@fachrifaul @Lyokone @russellwheatley @ellet0
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close