•  


fix unit tests by themiswang · Pull Request #12553 · firebase/firebase-ios-sdk · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit tests #12553

Merged
merged 3 commits into from
Mar 14, 2024
Merged

fix unit tests #12553

merged 3 commits into from
Mar 14, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Mar 14, 2024 •
edited

Fix incorrect unit test.

Test on sponge as well it passed: https://fusion2.corp.google.com/invocations/03e0c2a3-996d-4225-91dc-f8b702ecbaaf/targets

#no-changelog

@paulb777
Copy link
Member

Looks like there are still failures or flakes?

@themiswang
Copy link
Contributor Author

Looks like there are still failures or flakes?

Yeah, I removed all unnecessary expectation seems work now, also reran sponge and updated the link to pr description.

@themiswang themiswang marked this pull request as ready for review March 14, 2024 18:03
@themiswang themiswang merged commit ca73735 into main Mar 14, 2024
59 checks passed
@themiswang themiswang deleted the fixRCUnitTest branch March 14, 2024 18:05
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 9, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
0198e45 
….24.0" (
#1007
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](
https://togithub.com/firebase/firebase-ios-sdk
)
| minor | `from: "10.23.1"` -> `from: "10.24.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.24.0`](
https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.24.0
):
Firebase Apple 10.24.0

[Compare
Source](
https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.1...10.24.0
)

The Firebase Apple SDK (10.24.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](
https://firebase.google.com/support/release-notes/ios#10.24.0
)

To install this SDK, see [Add Firebase to your
project.](
https://firebase.google.com/docs/ios/setup
)

#### What's Changed

- Remove calls to fstat in crashlytics by
[@&#8203;volantwish](
https://togithub.com/volantwish
) in
[
firebase/firebase-ios-sdk#12531

- fix unit tests by
[@&#8203;themiswang](
https://togithub.com/themiswang
) in
[
firebase/firebase-ios-sdk#12553

- \[Release] Add release note for signed artifact changes by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12558

- Fix typo by [@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12565

- \[Firestore] Add a check to ensure FirestoreInternal has same public
headers as Firestore by [@&#8203;ncooke3](
https://togithub.com/ncooke3
)
in
[
firebase/firebase-ios-sdk#12575

- Carthage 10.23.0 by [@&#8203;paulb777](
https://togithub.com/paulb777
)
in
[
firebase/firebase-ios-sdk#12588

- Initial CI for visionOS by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12578

- Upgrade cmake build to grpc 162 by
[@&#8203;wu-hui](
https://togithub.com/wu-hui
) in
[
firebase/firebase-ios-sdk#12417

- More visionOS CI by [@&#8203;paulb777](
https://togithub.com/paulb777
)
in
[
firebase/firebase-ios-sdk#12608

- Update versions for Release 10.24.0 by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12594

- \[Release Tooling] Update XCFramework structure by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12595

- \[Docs] Update `FirebaseCore/CHANGELOG.md` with correct issue # by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12639

- Adds putFileHandle and putFileHandleAsync by
[@&#8203;mattcomi](
https://togithub.com/mattcomi
) in
[
firebase/firebase-ios-sdk#12580

- \[CocoaPods] Lock FirestoreInternal version to Firestore by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12654

- Merge 10.23.1 by [@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12655

- \[Crashlytics] Fix missing Swift header error by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12659

- Move MIEQ to composite index tests by
[@&#8203;milaGGL](
https://togithub.com/milaGGL
) in
[
firebase/firebase-ios-sdk#12416

- feat: add basic support to build frameworks and zip them for the Apple
Watch by [@&#8203;jasesuperhero](
https://togithub.com/jasesuperhero
) in
[
firebase/firebase-ios-sdk#12624

- Release note for watchOS zip/Carthage by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12670

- \[Crashlytics] Remove mach_absolute_time usages by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12664

- Update to SwiftFormat 0.53.5 by
[@&#8203;paulb777](
https://togithub.com/paulb777
) in
[
firebase/firebase-ios-sdk#12665

- Fix typo: Timout -> Timeout by
[@&#8203;Jager-yoo](
https://togithub.com/Jager-yoo
) in
[
firebase/firebase-ios-sdk#12672

- \[Crashlytics] Regenerate privacy manifest by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12675

- \[Release] Version changelog entries for 10.24.0 by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12677

- \[Release Tooling] Fix METADATA.md regression introduced in
[#&#8203;12595](
https://togithub.com/firebase/firebase-ios-sdk/issues/12595
)
by [@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12661

- Analytics 10.24.0 by
[@&#8203;tsunghung](
https://togithub.com/tsunghung
) in
[
firebase/firebase-ios-sdk#12693

- \[Release] Update binary SPM Firestore distro for 10.24.0 by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12708

- \[Release] Update Firestore's binary deps in Package.swift by
[@&#8203;ncooke3](
https://togithub.com/ncooke3
) in
[
firebase/firebase-ios-sdk#12709


#### New Contributors

- [@&#8203;volantwish](
https://togithub.com/volantwish
) made their first
contribution in
[
firebase/firebase-ios-sdk#12531

- [@&#8203;mattcomi](
https://togithub.com/mattcomi
) made their first
contribution in
[
firebase/firebase-ios-sdk#12580

- [@&#8203;jasesuperhero](
https://togithub.com/jasesuperhero
) made their
first contribution in
[
firebase/firebase-ios-sdk#12624

- [@&#8203;Jager-yoo](
https://togithub.com/Jager-yoo
) made their first
contribution in
[
firebase/firebase-ios-sdk#12672


**Full Changelog**:
firebase/firebase-ios-sdk@
10.23.1...10.24.0


</details>

---

### Configuration

?? **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

?? **Automerge**: Enabled.

? **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

?? **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](
https://togithub.com/renovatebot/renovate/discussions
) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](
https://togithub.com/renovatebot/renovate
).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub . Already have an account? Sign in .
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ddnan ddnan ddnan approved these changes

@danasilver danasilver Awaiting requested review from danasilver

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
@themiswang @paulb777 @ddnan @google-oss-bot
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close