•  


p2p/enode: fix endpoint determination for IPv6 by fjl · Pull Request #29801 · ethereum/go-ethereum · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p/enode: fix endpoint determination for IPv6 #29801

Merged
merged 3 commits into from
May 23, 2024
Merged

p2p/enode: fix endpoint determination for IPv6 #29801

merged 3 commits into from
May 23, 2024

Conversation

fjl
Copy link
Contributor

enode.Node has separate accessor functions for getting the IP , UDP port and TCP port. These methods performed separate checks for attributes set in the ENR.

With this PR, the accessor methods will now return cached information, and the endpoint is determined when the node is created. The logic to determine the preferred endpoint is now more correct, and considers how 'global' each address is when both IPv4 and IPv6 addresses are present in the ENR.

This is an alternative to #29736 .

@fjl fjl mentioned this pull request May 17, 2024
Closed
@fjl
Copy link
Contributor Author

Still a bit WIP, needs some more fixes to tests.

holiman
holiman approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

LGTM

@fjl
Copy link
Contributor Author

fjl commented May 21, 2024 •
edited

Fixed the test by allowing unspecified IP in node. I'm doing this to allow nodes with 0.0.0.0 to round-trip the enode:// URL encoding/parsing. We check for a valid IP in discovery, so it shouldn't cause any issues.

@fjl fjl added this to the 1.14.4 milestone May 23, 2024
@fjl fjl merged commit cc9e2bd into ethereum : master May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.4
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
@fjl @holiman
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close