•  


LanceDB Integration by PrashantDixit0 · Pull Request #1320 · embedchain/embedchain · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanceDB Integration #1320

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

PrashantDixit0
Copy link

@PrashantDixit0 PrashantDixit0 commented Mar 16, 2024

Description

This PR adds LanceDB vector database.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have written tests for the LanceDB vector database in tests/vectordb/test_lancedb.py

  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@AyushExel
Copy link

hey guys can we let this reviewed? Thanks!

@LeonieFreisinger
Copy link
Contributor

@PrashantDixit0 thanks for proposing these changes. I had a look at your code. There are 2 minor problems with the imports.
embedchain/config/vectordb/lancedb.py :
please correct the import line to
from embedchain.helpers.json_serializable import register_deserializable

tests/vectordb/test_lancedb.py:
please correct import line to:

from embedchain.config import AppConfig
from embedchain.config.vectordb.lancedb import LanceDBConfig

Further, lancedb is not yet added to the factory.py and the misc.py . Can you add this?

@PrashantDixit0
Copy link
Author

PrashantDixit0 commented May 17, 2024

@LeonieFreisinger Thank you for highlighting it, I have added these changes. Is it now good to merge?

@LeonieFreisinger
Copy link
Contributor

@PrashantDixit0 What example did you use to test your code? Can you provide me with a quick example and a sample config? Thanks.
Could you also add an example to the docs?

@PrashantDixit0
Copy link
Author

Sure @LeonieFreisinger , I'll add an example notebook in notebooks folder

@PrashantDixit0
Copy link
Author

@LeonieFreisinger , I have added an example notebook and tested the whole flow. Is it good to merge?

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본