•  


[Bug Fix] Fix issue of loading other languages in csv file by Ukong0324 · Pull Request #1225 · embedchain/embedchain · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix issue of loading other languages in csv file #1225

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Ukong0324
Copy link
Contributor

Description

An error occurred in the process of loading csv written in Korean, so the reading method was fixed.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Converted read process to utf-8 and loaded csv file

Example csv

이름,電話番號
테스트,010-1234-5678

Test Source

import
 os

from
 embedchain
 import
 App

from
 dotenv
 import
 load_dotenv


load_dotenv
()
openai_api_key
 =
 os
.
getenv
(
'OPENAI_API_KEY'
)

app
 =
 App
()
app
.
add
(
'/path/to/file.csv'
, 
data_type
=
'csv'
)  
# type: ignore

app
.
query
(
"테스트 電話番號"
)
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 28, 2024
@deshraj deshraj merged commit fb0852f into embedchain : main Jun 8, 2024
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본