•  


[Feature] Add Excel Loader to load .xlsx by eren-darici · Pull Request #1145 · embedchain/embedchain · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Excel Loader to load .xlsx #1145

Closed
wants to merge 3 commits into from
Closed

[Feature] Add Excel Loader to load .xlsx #1145

wants to merge 3 commits into from

Conversation

eren-darici
Copy link

@eren-darici eren-darici commented Jan 8, 2024 •
edited

Description

  • Excel Loader created
  • Dependencies added
  • Basic tests are created

How Has This Been Tested?

  • Created test_excel.py which includes multi-sheet validation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes most issues related Excel
  • Made sure Checks passed

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 8, 2024
deshraj
deshraj reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Overall looks great. Left a minor comment.

Thanks for the contrbution. ?? ??

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
deven298
deven298 suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@deven298 deven298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Left few comments. Thanks for adding this btw! ??

embedchain/loaders/excel.py Show resolved Hide resolved
embedchain/loaders/excel.py Outdated Show resolved Hide resolved
@deven298
Copy link
Contributor

LGTM!

@eren-darici Could you please resolve the conflicts? Also, it would be great it you can add docs for this here .
I will merge this and release it in next package release.

deshraj
deshraj reviewed Jun 5, 2024
View reviewed changes
pyproject.toml
@@ -148,6 +148,8 @@ google-auth-oauthlib = { version = "^1.2.0", optional = true }
google-auth = { version = "^2.25.2", optional = true }
google-auth-httplib2 = { version = "^0.2.0", optional = true }
google-api-core = { version = "^2.15.0", optional = true }
pandas = {version = "^2.1.4", optional = true}
openpyxl = {version = "^3.1.2", optional = true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Do you need this dependency? I don't see it getting used anywhere though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Those are optional for loading Excel files as the Excel Loader depends on pandas and pandas uses openpyxl (or xlsxwriter).

@deshraj
Copy link
Collaborator

deshraj commented Jun 14, 2024 •
edited

Seems like the PR has been inactive. Closing this now. Feel free to reopen if conflicts are resolved.

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@deshraj deshraj deshraj left review comments

@deven298 deven298 deven298 requested changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@eren-darici @deven298 @deshraj
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close