•  


SemIR fidelity when representing rewrite semantics by chandlerc · Pull Request #3833 · carbon-language/carbon-lang · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemIR fidelity when representing rewrite semantics #3833

Merged
merged 10 commits into from
May 23, 2024
Merged

SemIR fidelity when representing rewrite semantics #3833

merged 10 commits into from
May 23, 2024

Conversation

chandlerc
Copy link
Contributor

@chandlerc chandlerc commented Mar 29, 2024 •
edited

The toolchain's Semantic IR should start off modeling the full,
complex, and rich library-based and generic extension point semantics of Carbon
without eliding any layers or rewrites for compile time efficiency. We shouldn't
front-load elision or optimization when implementing the designs.

Once we have a full-fidelity implementation, we should work to build an
efficient elision, short-circuit, or common case simplification into the design
itself sufficient to make the SemIR model efficient. Only if we cannot find a
reasonable approach for that should we diverge the SemIR model to optimize its
efficiency, and we should preserve full fidelity in an optional mode.

@chandlerc chandlerc added proposal A proposal proposal draft Proposal in draft, not ready for review labels Mar 29, 2024
@chandlerc chandlerc force-pushed the semir-rewrite-fidelity branch 2 times, most recently from 94a605c to 96f3fcb Compare March 29, 2024 07:27
@chandlerc chandlerc marked this pull request as ready for review March 29, 2024 07:28
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Mar 29, 2024
josh11b
josh11b reviewed Mar 30, 2024
View reviewed changes
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Outdated Show resolved Hide resolved
jonmeow
jonmeow reviewed Apr 1, 2024
View reviewed changes
testing/file_test/autoupdate.cpp Outdated Show resolved Hide resolved
proposals/p3833.md Show resolved Hide resolved
@chandlerc
Copy link
Contributor Author

(the brief diff issues should be fixed now, sorry for that)

@chandlerc chandlerc force-pushed the semir-rewrite-fidelity branch 2 times, most recently from e588bd6 to 3809e49 Compare April 7, 2024 20:21
@jonmeow jonmeow mentioned this pull request Apr 24, 2024
Merged
zygoloid
zygoloid reviewed Apr 24, 2024
View reviewed changes
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Show resolved Hide resolved
chandlerc
chandlerc commented May 2, 2024
View reviewed changes
Copy link
Contributor Author

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Thanks for comments, most addressed, and one follow-up question inline!

proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Outdated Show resolved Hide resolved
proposals/p3833.md Show resolved Hide resolved
chandlerc and others added 6 commits May 8, 2024 19:02
@chandlerc
SemIR fidelity when representing rewrite semantics
9b2dbb8 
The toolchain's [Semantic IR][semir] should start off modeling the full,
complex, and rich library-based and generic extension point semantics of Carbon
without eliding any layers or rewrites for compile time efficiency. We shouldn't
front-load elision or optimization when implementing the designs.

Once we have a full-fidelity implementation, we should work to build an
efficient elision, short-circuit, or common case simplification into the design
itself sufficient to make the SemIR model efficient. Only if we cannot find a
reasonable approach for that should we diverge the SemIR model to optimize its
efficiency, and we should preserve full fidelity in an optional mode.

[semir]:
    
https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.503m6lfcnmui
@chandlerc
add example
40c2557
@chandlerc
fixes
43b0eb9
@chandlerc @josh11b
Update proposals/p3833.md
0bee0f8 
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
@chandlerc
further detail in example
977f8ac
@chandlerc
Improve based on review.
c5538de
@chandlerc
Copy link
Contributor Author

(Fixed weird mis-merge, sorry about that)

@zygoloid zygoloid mentioned this pull request May 11, 2024
Merged
chandlerc
chandlerc commented May 17, 2024
View reviewed changes
Copy link
Contributor Author

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

PTAL, I think the comments are addressed now?

@chandlerc
Copy link
Contributor Author

Ping? It's been a while since update...

zygoloid
zygoloid approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Looks good, let's move forward with this. Apologies for the delay.

proposals/p3833.md Outdated Show resolved Hide resolved
@chandlerc @zygoloid
Update proposals/p3833.md
f7052df 
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@chandlerc @CarbonInfraBot
Update proposals/p3833.md
0ce0af1 
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
@chandlerc chandlerc added this pull request to the merge queue May 23, 2024
Merged via the queue into carbon-language : trunk with commit 31060ca May 23, 2024
7 checks passed
@chandlerc chandlerc deleted the semir-rewrite-fidelity branch May 23, 2024 22:43
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@josh11b josh11b josh11b left review comments

@jonmeow jonmeow jonmeow left review comments

@CarbonInfraBot CarbonInfraBot CarbonInfraBot left review comments

@zygoloid zygoloid zygoloid approved these changes

@KateGregory KateGregory Awaiting requested review from KateGregory

Assignees
No one assigned
Labels
proposal rfc Proposal with request-for-comment sent out proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
@chandlerc @zygoloid @josh11b @jonmeow @CarbonInfraBot
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close