•  


chore: migrate to gh actions by bshaffer · Pull Request #1018 · bshaffer/oauth2-server-php · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to gh actions #1018

Merged
merged 50 commits into from
Apr 19, 2022
Merged

chore: migrate to gh actions #1018

merged 50 commits into from
Apr 19, 2022

Conversation

bshaffer
Copy link
Owner

No description provided.

@snapshotpl
Copy link
Contributor

You can try https://github.com/Yoast/PHPUnit-Polyfills to fix issues on older PHP versions

@snapshotpl
Copy link
Contributor

Or we should consider drop old PHP version support

@trylika
Copy link

we are talking about php 5.6/7.0/7.1 versions, which are currently ancient, i would definitely suggest making life easier by dropping them

@kristijonasb
Copy link

+1 for dropping support for older versions.

@trylika
Copy link

@bshaffer any news?

@bshaffer
Copy link
Owner Author

Okay I dropped support for 7.0 as well, and we should be able to merge this soon.

One question though... why is this a priority to the people on this thread? This does not add support or compatibility, it only affects the test suite. So I'm confused how something could be reliant on any of the changes being made here.

Thanks!

@bshaffer bshaffer merged commit 60254fc into master Apr 19, 2022
@bshaffer bshaffer deleted the migrate-to-gh-actions branch April 19, 2022 18:41
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본