•  


fix(material/card): Adds original padding for a card footer by lsamboretrorabbit · Pull Request #28833 · angular/components · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/card): Adds original padding for a card footer #28833

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(material/card): Adds original padding for a card footer #28833

wants to merge 2 commits into from

Conversation

lsamboretrorabbit
Copy link
Contributor

The mat-progress-bar overflows when placed in the mat-card-footer. Content should not extend beyond the borders of the card

Fixes #28785

@lsamboretrorabbit
fix(material/card): Adds original padding for a card footer
b1579f7 
The mat-progress-bar overflows when placed in the mat-card-footer.
Content should not extend beyond the borders of the card

Fixes
 angular#28785
crisbeto
crisbeto reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

I'm not sure that this is the right way to fix it. I think that we either:

  1. Just remove the example with the progress bar. I don't think it's in the spec anymore.
  2. Add overflow: hidden.

@lsamboretrorabbit
fix(material/card): Adds original padding for a card footer
d2c4e31 
The mat-progress-bar overflows when placed in the mat-card-footer.
Content should not extend beyond the borders of the card

Removed the display: flex property as it is not required for the footer component

Fixes
 angular#28785
@lsamboretrorabbit
Copy link
Contributor Author

@crisbeto I have made updates to the SCSS file

  1. Removed the display flex property as it not required for the footer component
  2. Provided a snapshot of how the progress bar looks within the footer

image

@lsamboretrorabbit lsamboretrorabbit mentioned this pull request Apr 10, 2024
Open
1 task
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(material/card): The mat-progress-bar overflows when placed in the mat-card-footer
2 participants
@lsamboretrorabbit @crisbeto
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close