•  


Successfully replaced the rule by HemanthPaila · Pull Request #2757 · airbnb/javascript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successfully replaced the rule #2757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Successfully replaced the rule #2757

wants to merge 1 commit into from

Conversation

HemanthPaila
Copy link

@HemanthPaila HemanthPaila commented Apr 2, 2023 •
edited by ljharb

Fixes #2689

Duplicate of #2756 .

ljharb
ljharb requested changes Apr 2, 2023
View reviewed changes
packages/eslint-config-airbnb-base/rules/style.js
before: 'always',
after: 'always',
}],
// Require or disallow padding lines between statements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Suggested change
// Require or disallow padding lines between statements
// Require or disallow padding lines between statements

packages/eslint-config-airbnb-base/rules/style.js
@@ -184,12 +184,9 @@ module.exports = {
// enforces empty lines around comments
'lines-around-comment': 'off',

// require or disallow newlines around directives
// https://eslint.org/docs/rules/lines-around-directive
'lines-around-directive': ['error', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

please don't delete an entry, just add the new one

packages/eslint-config-airbnb-base/rules/style.js
}],
// Require or disallow padding lines between statements
// https://eslint.org/docs/rules/padding-line-between-statements
'padding-line-between-statements': 'off',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

there's a lot of config here that isn't specified. Please include a config that matches the lines-around-directive config we already have.

@ljharb ljharb marked this pull request as draft April 2, 2023 06:19
@ljharb ljharb mentioned this pull request Apr 2, 2023
Open
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

@sandeepvinnu sandeepvinnu sandeepvinnu approved these changes

@huynhdev24 huynhdev24 huynhdev24 approved these changes

@Bazukakape Bazukakape Bazukakape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lines-around-directive rule should replaced with padding-line-between-statements
5 participants
@HemanthPaila @ljharb @sandeepvinnu @huynhdev24 @Bazukakape
- "漢字路" 한글한자자동변환 서비스는 교육부 고전문헌국역지원사업의 지원으로 구축되었습니다.
- "漢字路" 한글한자자동변환 서비스는 전통문화연구회가 "울산대학교한국어처리연구실 옥철영(IT융합전공)교수팀"에서 개발한 한글한자자동변환기를 바탕하여 지속적으로 공동 연구 개발하고 있는 서비스입니다.
- 현재 고유명사(인명, 지명등)을 비롯한 여러 변환오류가 있으며 이를 해결하고자 많은 연구 개발을 진행하고자 하고 있습니다. 이를 인지하시고 다른 곳에서 인용시 한자 변환 결과를 한번 더 검토하시고 사용해 주시기 바랍니다.
- 변환오류 및 건의,문의사항은 juntong@juntong.or.kr로 메일로 보내주시면 감사하겠습니다. .
Copyright ⓒ 2020 By '전통문화연구회(傳統文化硏究會)' All Rights reserved.
 한국   대만   중국   일본 

Close