한국   대만   중국   일본 
? T357399 Create GlobalBlockingConnectionProvider
Page Menu Home Phabricator

Create GlobalBlockingConnectionProvider
Closed, Resolved Public 1 Estimated Story Points

Description

A service is needed that allows callers to get a database connection to the virtual-globalblocking database domain. This will replace the methods in the GlobalBlocking.php static utility class.

QA Results - Local

Related Objects

Status Subtype Assigned Task
In Progress Niharika
Open None
Open None
Open None
Duplicate None
Open Skizzerz
Open ? Dreamy_Jazz
Open None
Open None
Open None
Open None
Open ? Dreamy_Jazz
Open ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Open ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Open ? Dreamy_Jazz
Resolved Tchanders
Resolved ? Dreamy_Jazz
Open ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved Marostegui
Resolved Marostegui
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Open None
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz
Resolved ? Dreamy_Jazz

Event Timeline

Change 1002970 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

Change 1002970 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

Suggested steps for QA:

  1. Install GlobalBlocking , if not already installed
  2. Log into an account with steward rights if you have MediaWiki-extensions-CentralAuth installed or an account that has the globalblock right (you can give this right to admins using $wgGroupPermissions['sysop']['globalblock'] = true; in LocalSettings.php )
  3. Use Special:GlobalBlock to make a global block on an IP address
  4. Load Special:GlobalBlockList
  5. Verify that the global block you applied appears in the list of global blocks.

These steps were designed to verify that no changes to the on-wiki interface have been made by this patch (as this ticket and patch refactored existing code without changing functionality). You may wish to test that nothing changed compared to running these steps on a wiki which does not have this change applied.

@Dreamy_Jazz Nothing changed as previously and has the same functions as seen in screenshots and .webm. This will be moved to Done. Thanks for all your work!

Status: ?PASS
Environment: Local: 1.42.0-alpha ( f3389a3 )23:25, 16 February 2024; GlobalBlocking: commit 093123a6b8b990b96061450874cfac5235d347e8 & bffe54f3cbc809dd36389ea26e9ca05f631b3414
OS: macOS Sonoma 14.2.1
Browser: Chrome 121
Skins. Vector 2022
Device: MBA M2
Emulated Device: : n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#

?AC1: https://phabricator.wikimedia.org/T352491

Steward rights Global Block Global Block List User Block After Expiration IP Range Global Block IP Range Global Block List
2024-02-16_09-44-36.png (1×1 px, 212 KB)
2024-02-16_10-27-51.png (769×1 px, 130 KB)
2024-02-16_10-28-17.png (617×2 px, 161 KB)
2024-02-16_10-30-07.png (528×2 px, 168 KB)
2024-02-16_10-41-18.png (1×3 px, 209 KB)
2024-02-16_10-43-46.png (752×2 px, 156 KB)
2024-02-16_10-44-17.png (614×2 px, 159 KB)

'Latest Patch'

2/9 Patch

2024-02-16_18-34-10.png (491×973 px, 84 KB)