한국   대만   중국   일본 
? T311415 Log entry in global block message should use mw-logevent-loglines class
Page Menu Home Phabricator
Create Task
Maniphest T311415

Log entry in global block message should use mw-logevent-loglines class
Closed, Resolved Public
Actions

Description

Currently, the global block message is visibly different from the local one:

unstyled global block log entry.png (333×2 px, 65 KB)

This is because the "global block log entry [...] provided below" is unstyled. The ul should use the mw-logevent-loglines class, as done by local block and also global lock (also page deletion etc.) notices. This is how it looks with the class:
styled global block log entry.png (333×2 px, 60 KB)

Details

Subject Repo Branch Lines +/-
Add mw-logevent-loglines class to ul element mediawiki/extensions/GlobalBlocking master +5 -1
Customize query in gerrit

Event Timeline

1234qwer1234qwer4 created this task. Jun 27 2022, 2:10 PM
Restricted Application added a subscriber: Aklapper . · View Herald Transcript Jun 27 2022, 2:10 PM
1234qwer1234qwer4 added a comment. Oct 5 2022, 10:03 PM

Just noting that Special:GlobalBlockList has a similar issue.

gerritbot added a comment. Oct 14 2022, 12:00 AM

Change 842473 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/extensions/GlobalBlocking@master] Add mw-logevent-loglines class to ul element

https://gerrit.wikimedia.org/r/842473

gerritbot added a project: Patch-For-Review . Oct 14 2022, 12:00 AM
Stang subscribed. Oct 14 2022, 12:14 AM

Found no difference between adding such class and not in Special:GlobalBlockList . A little bit off topic, since Special:BlockList use table to illustrate, maybe globalblocklist could show those logs in table as well.

gerritbot added a comment. Feb 15 2024, 5:33 PM

Change 842473 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add mw-logevent-loglines class to ul element

https://gerrit.wikimedia.org/r/842473

? Dreamy_Jazz closed this task as Resolved . Feb 15 2024, 5:37 PM
? Dreamy_Jazz claimed this task.
? Dreamy_Jazz removed a project: Patch-For-Review .
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20) . Feb 15 2024, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL