한국   대만   중국   일본 
? T274825 lots of calls being made to "suggest" api and app gets slow and heavy
Page Menu Home Phabricator
Create Task
Maniphest T274825

lots of calls being made to "suggest" api and app gets slow and heavy
Closed, Resolved Public
Actions

Description

lots of calls being made to "suggest" api and app gets slow and heavy especially on low end phones.
Steps:

  1. go to https://sx.wmflabs.org/index.php/Special:ContentTranslation
  2. click the first suggested article
  3. click the X button to go back to the dashboard

Expected results:

  • only 5 articles show on the suggestions list

Actual results:

  • 168 articles are loaded

image.png (510×1 px, 176 KB)

Details

Subject Repo Branch Lines +/-
SX: Performance fixes for vuex fetch actions mediawiki/extensions/ContentTranslation master +42 -13
Customize query in gerrit

Event Timeline

? Jpita created this task. Feb 15 2021, 10:03 PM
Restricted Application added a subscriber: Aklapper . · View Herald Transcript Feb 15 2021, 10:03 PM
Pginer-WMF triaged this task as Medium priority. Feb 16 2021, 7:52 AM
Pginer-WMF added a project: Language-Team (Language-2021-January-March) .
Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-January-March) board.
gerritbot added a comment. Feb 16 2021, 10:27 AM

Change 664520 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX: Performance fixes for vuex fetch actions

https://gerrit.wikimedia.org/r/664520

gerritbot added a project: Patch-For-Review . Feb 16 2021, 10:27 AM
ngkountas claimed this task. Feb 16 2021, 10:28 AM
ngkountas moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-January-March) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-January-March) board.
? Jpita added a comment. Feb 24 2021, 5:47 PM

NOTE TO QA:
try this when this is deployed in sx-labs

gerritbot added a comment. Mar 1 2021, 11:01 AM

Change 664520 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX: Performance fixes for vuex fetch actions

https://gerrit.wikimedia.org/r/664520

Maintenance_bot removed a project: Patch-For-Review . Mar 1 2021, 11:11 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02) . Mar 1 2021, 1:00 PM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-January-March) board. Mar 3 2021, 7:55 AM
? Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2021-January-March) board. Mar 3 2021, 9:54 PM
? Jpita moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-January-March) board. Mar 8 2021, 11:24 PM
Pginer-WMF closed this task as Resolved . Mar 23 2021, 9:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL